This repository has been archived by the owner on Jun 3, 2021. It is now read-only.
[jsfm] add try catch for callback function and event handler #1373
+15
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
421991e
to
cb22b8a
Compare
imyzf
approved these changes
Jul 25, 2018
wqyfavor
pushed a commit
to lucky-chen/incubator-weex
that referenced
this pull request
Jul 27, 2018
* apache/master: [WEEX-542][Android] rm useless code [WEEX-535][iOS] add extMsg when reproteror for windmill * [iOS] parser type by reg [WEEX-541][iOS]Vertical Pan may not trigger 'start' event on some devices. [WEEX-495][iOS] Fix class_replaceMethod param error in WXSwizzleInstanceMethod. [WEEX-539][Android] report container info when report error or performance * [Android] Fix transition createLayoutPropertyValueHolder * [android] Use rint on getFloatByViewport. * [android] Fix setViewport when debug # This is a combination of 2 commits. # This is the 1st commit message: [jsfm] add try catch for callback function and event handler (apache#1373) [WEEX-538][Android] do not shutdown websocket when debug * [Android] Add more log when callNative failed. * [Android] Add JS Error Log in GraphicActionAddElement
yxping
pushed a commit
to yxping/incubator-weex
that referenced
this pull request
Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In practice, most js error happens in the js bundle code, which could be a callback function or event handler of js framework. Add try catch on them could make js framework more stable and reduce js crashes.