[Android] record ipc exception history and weexCoreThread stackTrace … #2826

lucky-chen · 2019-08-14T08:16:37Z

[Android] record ipc exception history and weexCoreThread stackTrace when white screen or js process died/reload

weex-bot · 2019-08-14T08:32:19Z

	Warnings
⚠️	Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/performance/WXStateRecord.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️	Potential BREAK CHANGE. Modify public in android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java without metion it in commit message. You'd better add '@notdanger' in your commit log.
⚠️	No Changelog changes! - Can you add a Changelog? To do so,append your changes to the changelog.md
⚠️	Current pr not bind the milestone
⚠️	If your PR is about fixing a bug excluding crash the code,you should add the demo link in the PR description. Demo link: http://dotwe.org/vue

	Messages
📖	danger test finished.

Generated by 🚫 dangerJS against 3dee67e

Darin726 · 2019-08-14T08:42:57Z

android/sdk/src/main/java/com/taobao/weex/bridge/WXBridgeManager.java

@@ -876,6 +876,10 @@ public int callReportCrashReloadPage(String instanceId, String crashFile) {
        url = instance.getBundleUrl();
        instance.setHasException(true);
      }
+      Map<String,String> extInfo = new HashMap<>(1);


map 的 size 为啥不直接设置成 2

Darin726 · 2019-08-14T08:44:19Z

weex_core/Source/third_party/IPC/IPCFutexPageQueue.cpp

@@ -112,6 +112,7 @@ void IPCFutexPageQueue::lock(size_t id, bool checkFinish)
                break;
            }
            struct timespec waitTime = { m_timeoutSec, 0 };
+            LOGE("IPCException IPCFutexPageQueue:: start futex wait");


…when white screen or js process died/reload

Darin726

LGTM

Darin726

LGTM

lucky-chen requested review from Darin726, gubaojian and YorkShen as code owners August 14, 2019 08:16

Darin726 reviewed Aug 14, 2019

View reviewed changes

lucky-chen force-pushed the feature/ws_record_thread_ipc_info branch from d0ca1e2 to 69d16a2 Compare August 14, 2019 08:51

[Android] record ipc exception history and weexCoreThread stackTrace …

47650b6

…when white screen or js process died/reload

lucky-chen force-pushed the feature/ws_record_thread_ipc_info branch from 69d16a2 to 47650b6 Compare August 14, 2019 08:56

Darin726 approved these changes Aug 14, 2019

View reviewed changes

Merge branch 'master' into feature/ws_record_thread_ipc_info

3dee67e

Darin726 approved these changes Aug 14, 2019

View reviewed changes

Darin726 merged commit a994ce9 into apache:master Aug 14, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Android] record ipc exception history and weexCoreThread stackTrace … #2826

[Android] record ipc exception history and weexCoreThread stackTrace … #2826

[Android] record ipc exception history and weexCoreThread stackTrace … #2826

[Android] record ipc exception history and weexCoreThread stackTrace … #2826

Conversation

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment