[go: nahoru, domu]
Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[Android]fix storage 异步执行导致service执行异常的问题 #2010

Merged
merged 1 commit into from
Jan 10, 2019
Merged

[Android]fix storage 异步执行导致service执行异常的问题 #2010

merged 1 commit into from
Jan 10, 2019

Conversation

lvfen
Copy link
Contributor
@lvfen lvfen commented Jan 7, 2019

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link
weex-bot commented Jan 7, 2019 •
edited
Loading
Fails
🚫 Failed to run assembleDebug task for android.
Messages
📖 android build verification finished.

Generated by 🚫 dangerJS

lucky-chen
lucky-chen approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor
@lucky-chen lucky-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

YorkShen
YorkShen approved these changes Jan 10, 2019
View reviewed changes
Copy link
Contributor
@YorkShen YorkShen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YorkShen YorkShen merged commit 44cff24 into apache:master Jan 10, 2019
gubaojian pushed a commit to gubaojian/incubator-weex that referenced this pull request Jan 30, 2019
@lvfen @Darin726
* [Android] Fix storage problem due to multiple thread (apache#2010)
e5d1e58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@YorkShen YorkShen YorkShen approved these changes

@lucky-chen lucky-chen lucky-chen approved these changes

@gubaojian gubaojian Awaiting requested review from gubaojian

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lvfen @weex-bot @YorkShen @lucky-chen