[iOS] Fix bug that when imagesrc is nil, image loader is still called. #2145

wqyfavor · 2019-02-20T11:39:42Z

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

Update API docs for the component.
Update/Add demo to demonstrate new feature.
Update test scripts for the feature.
Add unit tests for the feature.

weex-bot · 2019-02-20T11:45:13Z

	Messages
📖	No android file has been changed.
📖	android build verification finished.

Generated by 🚫 dangerJS

jianhan-he

LGTM

apache#2145)

[iOS] Fix bug that when imagesrc is nil, image loader is still called.

8b92d6a

jianhan-he reviewed Feb 20, 2019

View reviewed changes

zshshr approved these changes Feb 20, 2019

View reviewed changes

zshshr merged commit 1fea212 into apache:master Feb 20, 2019

wqyfavor deleted the fix-image-nil-url branch February 20, 2019 11:52

Darin726 pushed a commit to Darin726/incubator-weex that referenced this pull request Mar 25, 2019

[iOS] Fix bug that when imagesrc is nil, image loader is still called. (

81af41d

apache#2145)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[iOS] Fix bug that when imagesrc is nil, image loader is still called. #2145

[iOS] Fix bug that when imagesrc is nil, image loader is still called. #2145

[iOS] Fix bug that when imagesrc is nil, image loader is still called. #2145

[iOS] Fix bug that when imagesrc is nil, image loader is still called. #2145

Conversation

Choose a reason for hiding this comment