[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart watch stream on error in WatcherService #5486

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

quintenp01
Copy link
Contributor

Add onError and onCompleted handlers for etcd watchAllKeys stream in WatcherService to restart it in case of a failure.

Description

We've observed when running the FPC Scheduler that on occasion when deploying ETCD the ContainerCounter will stop updating, causing namespace throttles when the actual container usage is well under the throttle limit.

Related issue and scope

  • I opened an issue to propose and discuss this change (#????)

My changes affect the following components

  • API
  • Controller
  • Message Bus (e.g., Kafka)
  • Loadbalancer
  • Scheduler
  • Invoker
  • Intrinsic actions (e.g., sequences, conductors)
  • Data stores (e.g., CouchDB)
  • Tests
  • Deployment
  • CLI
  • General tooling
  • Documentation

Types of changes

  • Bug fix (generally a non-breaking change which closes an issue).
  • Enhancement or new feature (adds new functionality).
  • Breaking change (a bug fix or enhancement which changes existing behavior).

Checklist:

  • I signed an Apache CLA.
  • I reviewed the style guides and followed the recommendations (Travis CI will check :).
  • I added tests to cover my changes.
  • My changes require further changes to the documentation.
  • I updated the documentation where necessary.

@quintenp01
Copy link
Contributor Author

@style95 Would you be able to take a look at this when you get a chance? Curious if you think this is an actual issue or not

Copy link
Member
@rabbah rabbah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but deferring to @style95

Copy link
Member
@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@quintenp01
Thank you for the update.
It looks good to me 👍

@bdoyle0182 bdoyle0182 merged commit 6246f6a into apache:master Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants