Fix binary license check issues and update jersey to 2.34 for Pulsar SQL #10682
Conversation
| @@ -230,6 +230,11 @@ | |||
| <artifactId>jersey-media-json-jackson</artifactId> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
Why do we need to specify the dependency here? Pinning the version in the dependencyManagement section in top level pom should be enough, no?
There was a problem hiding this comment.
O it isn't.
The dependencyManagement section is like a default configuration but it deos not mean that dependencies declared up there take precedence
| <dependency> | ||
| <groupId>jakarta.activation</groupId> | ||
| <artifactId>jakarta.activation-api</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
Same as above, not sure why we need to add it here
There was a problem hiding this comment.
I have excluded jakarta.activation-api in the root pom.xml of the jersey-media-json-jackson dependency, some components depends on jersey-media-json-jackson will also exclude the jakarta.activation-api, In this PR we just make sure Pulsar using the consistent version of jakarta.activation-api, not remove the dependency. So add jakarta.activation-api dependency for the components which depends on jersey-media-json-jackson before. I'm not sure if we can remove it directly.
| @@ -230,6 +230,11 @@ | |||
| <artifactId>jersey-media-json-jackson</artifactId> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
There was a problem hiding this comment.
O it isn't.
The dependencyManagement section is like a default configuration but it deos not mean that dependencies declared up there take precedence
…SQL (apache#10682) * Fix binary license check issues. * Fix binary license check issues. * Fix binary license check issues.
…SQL (apache#10682) * Fix binary license check issues. * Fix binary license check issues. * Fix binary license check issues.
jakarta.activation-api