[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[improve][broker] Follow up #4196 use PulsarByteBufAllocator handle OOM #20837

Merged
merged 1 commit into from
Jul 20, 2023
Merged

[improve][broker] Follow up #4196 use PulsarByteBufAllocator handle OOM #20837

merged 1 commit into from
Jul 20, 2023

Conversation

mattisonchao
Copy link
Member

Motivation

Follow up PR #4196 to use PulsarByteBufAllocator handle OOM

Modifications

  • Use PulsarByteBufAllocator to instead PooledBytebufAllocator

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

@mattisonchao mattisonchao self-assigned this Jul 19, 2023
@mattisonchao mattisonchao added this to the 3.2.0 milestone Jul 19, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 19, 2023
@mattisonchao mattisonchao reopened this Jul 19, 2023
@JooHyukKim JooHyukKim mentioned this pull request Jul 19, 2023
Closed
2 tasks
@Technoboy- Technoboy- modified the milestones: 3.2.0, 3.1.0 Jul 20, 2023
@mattisonchao mattisonchao reopened this Jul 20, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #20837 (5e5f079) into master (57fbee4) will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #20837      +/-   ##
============================================
+ Coverage     72.97%   73.21%   +0.24%     
- Complexity    32157    32242      +85     
============================================
  Files          1868     1868              
  Lines        139164   139188      +24     
  Branches      15314    15315       +1     
============================================
+ Hits         101555   101910     +355     
+ Misses        29562    29240     -322     
+ Partials       8047     8038       -9
Flag Coverage Δ
inttests 24.16% <10.00%> (?)
systests 25.16% <50.00%> (+0.11%) ⬆️
unittests 72.51% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ar/client/impl/PatternMultiTopicsConsumerImpl.java 89.81% <100.00%> (+3.96%) ⬆️
...ava/org/apache/pulsar/common/protocol/Markers.java 90.35% <100.00%> (ø)
...filesystem/impl/FileStoreBackedReadHandleImpl.java 56.47% <100.00%> (ø)

... and 87 files with indirect coverage changes

@mattisonchao mattisonchao merged commit ac94296 into apache:master Jul 20, 2023
99 of 106 checks passed
@mattisonchao mattisonchao deleted the follow_up/4196 branch July 20, 2023 15:20
lhotari pushed a commit that referenced this pull request Jun 13, 2024
@mattisonchao @lhotari
[improve][broker] Follow up #4196 use PulsarByteBufAllocator handle…
77966e2 
… OOM (#20837)

(cherry picked from commit ac94296)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Demogorgon314 Demogorgon314 Demogorgon314 approved these changes

@coderzc coderzc coderzc approved these changes

Assignees

@mattisonchao mattisonchao

Labels
cherry-picked/branch-3.0 doc-not-needed Your PR changes do not impact docs ready-to-test release/3.0.6
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
7 participants
@mattisonchao @codecov-commenter @Demogorgon314 @coderzc @lhotari @Technoboy- @liangyepianzhou