[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Improve error message when no columns in a SFrame have expected data type. #2324

Merged
merged 3 commits into from
Sep 20, 2019
Merged

Improve error message when no columns in a SFrame have expected data type. #2324

merged 3 commits into from
Sep 20, 2019

Conversation

jakesabathia2
Copy link
Collaborator
@jakesabathia2 jakesabathia2 commented Sep 18, 2019

Close #1231
Improve the error message for type checking.

Copy link
Collaborator
@TobyRoseman TobyRoseman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code change looks good. However you included adding a large image with this pull request. Please remove that file.

@jakesabathia2
Copy link
Collaborator Author

Just removed the image

Copy link
Collaborator
@nickjong nickjong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, could you edit the PR description so that merging this PR will close the affected issue? See also https://help.github.com/en/articles/closing-issues-using-keywords

Also, please give the PR a more descriptive name. Someone reading the PR title should have a sense of what the change does without having to look up the issue number. The same goes for the commit message!

@jakesabathia2 jakesabathia2 changed the title Better error for #1231 Improve error message when no columns in a SFrame have expected data type. Sep 20, 2019
@jakesabathia2 jakesabathia2 merged commit 037e112 into apple:master Sep 20, 2019
@jakesabathia2 jakesabathia2 deleted the toolkit_branch branch September 20, 2019 20:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ToolkitError: No list column in "dataset".
3 participants