[go: nahoru, domu]

Skip to content
This repository has been archived by the owner on Dec 21, 2023. It is now read-only.

Fixed subtle threading bug in column indexer of ml_data. #2979

Merged
merged 2 commits into from
Mar 2, 2020

Conversation

hoytak
Copy link
Collaborator
@hoytak hoytak commented Feb 4, 2020

Resolves #2966.

Copy link
Collaborator
@guihao-liang guihao-liang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been a long time that I haven't had fun. I feel really reinvigorated by reviewing this code. Thanks, Hoyt!

template <typename T>
void adjust_global_array_size(size_t idx, std::vector<T>& v) {
template <typename... V>
inline void check_global_array_sizes(size_t idx, V&... vv) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bravo!

@hoytak hoytak merged commit a16d9ad into apple:master Mar 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Diagnose and re-enable test dml_test_row_bounds.cxx
2 participants