[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content search for the KB #240

Open
itaysk opened this issue Oct 23, 2019 · 7 comments
Open

Add content search for the KB #240

itaysk opened this issue Oct 23, 2019 · 7 comments
Labels
enhancement New feature or request

Comments

@itaysk
Copy link
Collaborator
itaysk commented Oct 23, 2019

Currently the search is more like a lookup, where you can lookup an article by it's ID. We need a full text search to allow people to search for content freely.
@itaysk itaysk added the enhancement New feature or request label Oct 23, 2019
@iyehuda
Copy link
Contributor
iyehuda commented Oct 23, 2019

Can we run some backend logic on GitHub pages to do that?
What is the common way to do this on that platform?

@itaysk
Copy link
Collaborator Author
itaysk commented Oct 23, 2019

No. We can do client side, or server side hosted as a service. There are several of those that work with Jekyll like algolia/lunr just to give an example

@RobbiNespu
Copy link

how about something like this
Screenshot-20191024102538-962x673

RobbiNespu added a commit to RobbiNespu/kube-hunter that referenced this issue Oct 24, 2019
@RobbiNespu
full text search aquasecurity#240
a8b5bce
@RobbiNespu RobbiNespu mentioned this issue Oct 24, 2019
Closed
@itaysk
Copy link
Collaborator Author
itaysk commented Oct 24, 2019 •
edited

see my comments on the PR

@itaysk
Copy link
Collaborator Author
itaysk commented Oct 24, 2019

I think it would be best to use some external search indexing service. One option is Google custom search. It's free but ad supported. Another is Algolia which is free for not-commercial project which I guess we qualify.

@RaitoBezarius
Copy link
Contributor

That sounds overkill, this seems a more appropriate solution if possible: http://elasticlunr.com/

@itaysk
Copy link
Collaborator Author
itaysk commented Nov 1, 2019

@RaitoBezarius if that can support full text indexing (of the content) that's an option too

@itaysk itaysk added this to the v0.2.1 milestone Nov 12, 2019
@lizrice lizrice removed this from the v0.2.1 milestone Feb 14, 2020
@danielsagi danielsagi changed the title Add search for the KB Add content search for the KB Nov 28, 2020
py-go pushed a commit to py-go/kube-hunter that referenced this issue Aug 29, 2021
@danielpacak
feat: Add support for Trivy client-server mode (aquasecurity#240)
668f7a7 
Resolves: aquasecurity#213

Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@RaitoBezarius @lizrice @itaysk @RobbiNespu @iyehuda