[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hunters testable #319

Open
iyehuda opened this issue Mar 4, 2020 · 1 comment
Open

Make hunters testable #319

iyehuda opened this issue Mar 4, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@iyehuda
Copy link
Contributor
iyehuda commented Mar 4, 2020

What would you like to be added

Redefine hunters to get configuration as parameter.

Why is this needed

Following dependency inversion principal, and in order to write testable code, it is better that hunters will be initialized with config as parameter instead of referencing a global state variable.

@iyehuda iyehuda added the enhancement New feature or request label Mar 4, 2020
@gahag
Copy link
gahag commented Oct 5, 2020

Can I work on this?

py-go pushed a commit to py-go/kube-hunter that referenced this issue Aug 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants