[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fetch Fixes #49

Closed
wants to merge 25 commits into from
Closed

Fetch Fixes #49

Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
3ccefb2
fix fetch attempt
nicoburniske Apr 30, 2024
2d29ef5
fix fetch test by locking stream
nicoburniske Apr 30, 2024
d2636ec
enable all tests again
nicoburniske Apr 30, 2024
0473061
remove obsolete comment
nicoburniske Apr 30, 2024
fe217ce
fetch test body ReadableStream
nicoburniske Apr 30, 2024
98bf330
add post test (failing)
nicoburniske Apr 30, 2024
ba679d5
comment out headers only body post test
nicoburniske Apr 30, 2024
7975f3b
debugging fetch-3
nicoburniske May 1, 2024
6347825
add header logs
nicoburniske May 8, 2024
9bdfce6
Merge remote-tracking branch 'origin/main' into fetch-fix-updated
nicoburniske May 8, 2024
2e883a7
Debug and fix attempts
vigoo May 13, 2024
b509286
attempt to extract value before subscribing
nicoburniske May 13, 2024
a1df1ba
update fetch-3 unit test
nicoburniske May 13, 2024
0de1f11
More debug and fixes
vigoo May 13, 2024
ef48a6e
add async stream fetch test 4
nicoburniske May 20, 2024
383f138
remove debug stderror logs
nicoburniske May 20, 2024
717c191
Merge pull request #1 from nicoburniske/fetch-fix-updated
nicoburniske May 20, 2024
0ee4e92
Merge branch 'bytecodealliance:main' into main
nicoburniske May 20, 2024
b101905
small clean up
nicoburniske May 20, 2024
f666d6d
clean up
nicoburniske May 20, 2024
76f5f40
small cleanup
nicoburniske May 20, 2024
c9b42e4
small cleanup
nicoburniske May 20, 2024
62ea77d
more cleanup
nicoburniske May 20, 2024
d0bb3bf
remove fetch-4 test
nicoburniske May 20, 2024
f7aacf1
remove clean_test.sh
nicoburniske May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove obsolete comment
  • Loading branch information
@nicoburniske
nicoburniske committed Apr 30, 2024
commit 04730615e9c5550e2c147770eed1a97328a0aa19
1 change: 0 additions & 1 deletion builtins/web/fetch/fetch_event.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,6 @@ bool send_response(host_api::HttpOutgoingResponse *response, JS::HandleObject se
FetchEvent::State new_state) {
MOZ_ASSERT(FetchEvent::state(self) == FetchEvent::State::unhandled ||
FetchEvent::state(self) == FetchEvent::State::waitToRespond);
// This isn't always firing.
auto result = response->send(RESPONSE_OUT);
FetchEvent::set_state(self, new_state);

Expand Down