-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add numeric separator to shippedProposals
#10971
Add numeric separator to shippedProposals
#10971
Conversation
@@ -9,6 +9,7 @@ Using modules transform: auto | |||
|
|||
Using plugins: | |||
syntax-async-generators { "chrome":"71" } | |||
proposal-numeric-separator { "chrome":"71" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When corejs.proposals
is true
, we should not add proposal-numeric-separator
here because corejs.proposals
should not imply shippedProposals: true
.
dc8ef53
to
8ab6ff2
Compare
TopLevelOptions.shippedProposals, | ||
opts.shippedProposals, | ||
false, | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Practically it is not a breaking change, because we have never added any plugins to shippedProposals
. So even if corejs.proposals
implies shippedProposals
, our user can not observe the effect. I would consider this change as bugfix.
The failing e2e test is fixed on master |
610fda4
to
bf636ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The e2e test error is related: https://app.circleci.com/jobs/github/babel/babel/17386
Blocking this PR until the test error is fixed.
@Wetinee Because this is a new feature, can you also update https://babeljs.io/docs/en/babel-preset-env#shippedproposals and submit a PR? Here is the link to docs source. |
@Wetinee The failure happens when using an old version of Right after importing |
08d6f8f
to
8a47461
Compare
8a47461
to
810dfa5
Compare
The CI error is fixed by v7.8.7 |
Please enter the commit message for your changes. Lines starting
Storybook otherwise had a broken/incompatible version and we end up with this error in CI: https://app.circleci.com/pipelines/github/yunity/karrot-frontend/166/workflows/d7664456-b80f-4cc0-960f-07164329f038/jobs/24730 I think this is the related babel fix babel/babel#10971 We should remove this in the future, or solve it without forcing resolutions.
Storybook otherwise had a broken/incompatible version and we end up with this error in CI: https://app.circleci.com/pipelines/github/yunity/karrot-frontend/166/workflows/d7664456-b80f-4cc0-960f-07164329f038/jobs/24730 I think this is the related babel fix babel/babel#10971 We should remove this in the future, or solve it without forcing resolutions.
I've added numeric separator in babel-preset-env and babel-preset-dev-env, but failed some tests and I haven't found out why. Your help is greatly appreciated.