babel --watch
should have equivalent file selection logic with babel
#10283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we align file selection logic of
--watch
to one time building. Inbabel/packages/babel-cli/src/babel/file.js
Lines 144 to 163 in f08062b
The cli options
--extensions
is used to filter compilable files if thefilename
argument is a directory. However the watch logic excludes all non-compilable files even if it is specified infilename
argument.We also introduce minor performance tweak by passing
disableGlobbing: true
into chokidar as@babel/cli
does not support globbing.Fixture-based unit test does not work here since we need separate process to trigger a file change.