-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable eqeqeq
rule
#16404
Enable eqeqeq
rule
#16404
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56690 |
@@ -1128,6 +1128,7 @@ class Printer { | |||
if ( | |||
this._buf.hasContent() && | |||
(comment.type === "CommentLine" || | |||
// eslint-disable-next-line eqeqeq | |||
commentStartLine != commentEndLine) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need !=
here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I realize that null/undefined
shouldn't exist here.
@@ -35,6 +35,7 @@ module.exports = [ | |||
"no-process-exit": "error", | |||
"no-var": "error", | |||
"prefer-const": "error", | |||
eqeqeq: ["error", "smart"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Can we sort the rule alphabetically?
Fixes #1, Fixes #2