[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source map deps #16327

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Update source map deps #16327

merged 1 commit into from
Mar 5, 2024

Conversation

liuxingbaoyu
Copy link
Member
Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator
babel-bot commented Mar 5, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56421

@liuxingbaoyu liuxingbaoyu force-pushed the update-sourcemap branch 2 times, most recently from 37559de to 332697b Compare March 5, 2024 09:45
nicolo-ribaudo
nicolo-ribaudo reviewed Mar 5, 2024
View reviewed changes
packages/babel-traverse/test/fixtures/conversion/this-source-maps/source-map.json
@@ -13,5 +13,6 @@
"sourcesContent": [
"function fn() {\n var inner = () => {\n console.log(this);\n };\n}"
],
"mappings": "AAAA,SAASA,EAAEA,CAAA,EAAG;EAAA,IAAAC,KAAA;EACZ,IAAIC,KAAK,GAAG,SAAAA,CAAA,EAAM;IAChBC,OAAO,CAACC,GAAG,CAACH,KAAI,CAAC;EACnB,CAAC;AACH"
"mappings": "AAAA,SAASA,EAAEA,CAAA,EAAG;EAAA,IAAAC,KAAA;EACZ,IAAIC,KAAK,GAAG,SAAAA,CAAA,EAAM;IAChBC,OAAO,CAACC,GAAG,CAACH,KAAI,CAAC;EACnB,CAAC;AACH",
"ignoreList": []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, we can add injected inline helper functions to this ignoreList so that they are skipped by debuggers.

@nicolo-ribaudo nicolo-ribaudo merged commit 40110e9 into babel:main Mar 5, 2024
50 checks passed
liuxingbaoyu added a commit to liuxingbaoyu/babel that referenced this pull request Mar 5, 2024
@liuxingbaoyu
Update source map deps (babel#16327)
6282ebc
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Fixes failing main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liuxingbaoyu @babel-bot @JLHwung @nicolo-ribaudo