[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plot style #108

Merged
merged 10 commits into from
Oct 23, 2018
Merged

Update plot style #108

merged 10 commits into from
Oct 23, 2018

Conversation

mimischi
Copy link
Contributor
@mimischi mimischi commented Oct 18, 2018 •
edited
Loading

Fixes #96.

Changes made in this pull request:

  • Added option to set the plot DPI via --dpi.
  • Added option to set the plot font size via --font-size.
  • Added option to hide the linear scaling fit via --no-fit.
  • Added saner defaults for ylim.
  • Added custom xticks and yticks depending on the number of nodes/cores used and the benchmarks' performance.
  • xtick steps can be overwritten with the option --xtick-step.
  • Added a watermark (text: MDBenchmark) to the top left of the plot. It's added to every plot by default, but can easily be switched off with --no-watermark.

PR Checklist

  • Added changelog fragment in ./changelog/ (more information)?
  • Issue raised/referenced?

@mimischi mimischi force-pushed the plotstyle branch 2 times, most recently from d11cef7 to 0240052 Compare October 18, 2018 12:37
@mimischi mimischi requested a review from MSiggel October 18, 2018 13:11
@mimischi mimischi added this to In Progress in MDBenchmark 2.0 via automation Oct 18, 2018
@mimischi mimischi force-pushed the plotstyle branch 2 times, most recently from e196aba to 000d23a Compare October 22, 2018 12:17
@codecov
Copy link
codecov bot commented Oct 23, 2018 •
edited
Loading

Codecov Report

Merging #108 into develop will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #108      +/-   ##
===========================================
+ Coverage    96.34%   96.54%   +0.19%     
===========================================
  Files           14       14              
  Lines          684      723      +39     
===========================================
+ Hits           659      698      +39     
  Misses          25       25
Impacted Files Coverage Δ
mdbenchmark/plot.py 92.7% <100%> (+2.9%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9a97d...c808f01. Read the comment docs.

@mimischi mimischi merged commit 1554072 into develop Oct 23, 2018
MDBenchmark 2.0 automation moved this from In Progress to Done Oct 23, 2018
@mimischi mimischi deleted the plotstyle branch October 23, 2018 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSiggel MSiggel Awaiting requested review from MSiggel

Assignees
No one assigned
Labels
None yet
Projects
No open projects
MDBenchmark 2.0
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mimischi