Fix incompatibility of node versions 15.5+ and serverless-artillery causing "Empty lambda zip" errors in load tests #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaroloes
commented
Jun 7, 2021
| console.info('Serverless Artillery stack is already deployed. Skipping redeployment.') | ||
| return | ||
| } | ||
| console.info(`Serverless Artillery stack is in a wrong state: ${slsartStack?.StackStatus}. Redeploying.`) |
There was a problem hiding this comment.
I enhanced the check we were doing to see if we need to redeploy the serverless-artillery stack
alvaroloes
commented
Jun 7, 2021
| @@ -59,6 +59,7 @@ | |||
| "lint:fix": "eslint --quiet --fix --ext '.js,.ts' **/*.ts", | |||
| "compile": "ttsc -b tsconfig.json", | |||
| "clean": "rimraf ./dist tsconfig.tsbuildinfo", | |||
| "postinstall": "rimraf ../../node_modules/serverless/node_modules/archiver && echo 'Deleted buggy \"archiver\" module from \"serveless\" dependencies to use the newer hoisted one'", | |||
There was a problem hiding this comment.
This is the main change in this PR
Moneyba
approved these changes
Jun 9, 2021
c9b027b
to
3043f07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a "dependency-hell" chained error:
.endonzlib.DeflateRawwas changedarchiverto fail. Only the newest version has it fixed..zipwere empty. We fixed this by updating the AWS CDK that used a newer version ofarchiverserverless-artilleryusesserverlessto deploy the lambda that executes de load test.serverless, in turn, usesarchiverto zip the lambda's code. This means that we were getting the "empty lambda zip" error when deploying serverless-artillery for the load tests.serverlessuses the fixed version ofarchiver, but we can't use it because it is incompatible with the version we are using ofserverless-artillery.serverless-artillerybecause there is not newer versionChanges
The solution is to force the version of
serverlesswe are using (that's compatible withserverless-artillery) to use a newer version ofarchiver.The official way to do this (which is called "override dependencies") has still not reached the official version of node and NPM (official issue here)
The "un-official" way to do this is what is done in this PR:
node_modulesfolder (instead of inside each package)archiveris located at<root>/node_modules/archiverserverlessis using, is located in a transitive dependency in<root>/node_modules/serverless/node_modules/archiverserverlessmodule looks forarchiverand it doesn't find it in its local "node_modules" folder, it will search for it in the parent directory (this is how every node module lookup is done), finding the goodarchiverChecks
[ ] Updated documentation accordinglyAdditional information