Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ReadsHtsgetData source, refactor HtsgetReader #6662
base: master
Are you sure you want to change the base?
Implement ReadsHtsgetData source, refactor HtsgetReader #6662
Changes from 5 commits
a476ce7
ff50eec
aa4d48a
ba2dd80
0cb9530
dce337f
edda05c
3415528
74f7d70
890da67
c0cc6ee
8afa04b
946bb4b
100b0a4
c6a36cf
1022cbe
062d9ca
f166712
37eb57d
1e77370
f71ea84
7967843
c437c29
27e7dc7
a32a9e3
ea540d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very clean but we might want to keep the ability to tune by number of threads
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you seen that java actually runs the map operations in parallel and then rejoins them in the right oder? I'm not 100% sure that it's guaranteed to do either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll revert the change with the threads. Whether the stream is ordered/not ordered is separate from whether it's parallel/sequential, so the operations might run in parallel and out of order, but the
forEachOrdered
is makes sure they wait in order for the final step.