GenomicsDB on azure #8438
Merged
GenomicsDB on azure #8438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see I didn't respond here previously, but this branch has been working for me and is what I'm currently using. Would be great to get it merged along with #8470 |
0b5be67
to
8fd8e7f
Compare
|
Github actions tests reported job failures from actions build 6895762275
|
|
Github actions tests reported job failures from actions build 6896352136
|
e51318e
to
7b57c02
Compare
7b57c02
to
c6c875a
Compare
|
Github actions tests reported job failures from actions build 7143483544
|
c6c875a
to
5889662
Compare
|
Github actions tests reported job failures from actions build 7144734512
|
* GATK's lack of support for az:// uri means that although genomicsdb can natively read them, parts of the java code crash when they're passed through * Adding --avoid-nio and --header parameters these allow disabling all of the java codes interaction with the az:// links and simply pass them through to genomicsdb This disables some safeguards but allows operating on files in azure * Move GenomicsDB version to released 1.5.1 for azure improved support * There are no direct tests on azure since we do not yet have any infrastructure to generate the necessary tokens --------- Co-authored-by: Nalini Ganapati <nalini@datma.com> Co-authored-by: Nalini Ganapati <nalinigans@github.com>
5889662
to
de45517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding two new parameters which work together to allow passing through files from azure too genomicsDB
--header <vcf>which lets you specify a vcf file to use the header from as your merged header. Do not mess this up or you will likely be doomed.--avoid-niowhich disables GATK sanity checks that involve reading the files since this would require opening them on azure.This needs tests but I wanted to put it here for @meganshand to try.