feat(universe): enable targetting hosting environment dynamically #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
artdnlv
approved these changes
Mar 16, 2022
| super({ | ||
| injectables: { | ||
| // symmetric to the legacy implementation below | ||
| base: options.universeBase ?? `https://${options.name}.hello-charles.com` | ||
| base: options.universeBase ?? `https://${options.name}.${options.universeHost ?? 'hello-charles.com'}` |
There was a problem hiding this comment.
I'd suggest to move this hello-charles.com to some const DEFAULT_UNIVERSE_HOST
There was a problem hiding this comment.
does not work because of the TS compiler unfortunately, see ref in code or microsoft/TypeScript#8277
haayhappen
approved these changes
Mar 16, 2022
Because the we have a lot of branching in code now, which is not desired, and makes it a bit intransparent what host we are targeting. I believe the test though to be exhaustive and hope that the integration in the agent UI is represented by that. PR there following |
|
🎉 This PR is included in version 4.75.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Robert Jefe Lindstaedt robert.lindstaedt@gmail.com
it can easily break stuff in the agent UI once I would merge there. Potentially I will break the dev build temporarily, but I do not see a way around it.
We will need it for hosting universes e.g. at charlesuniversesdev.com