[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Floating window does not show Peleton row targets #2026

Closed
k818mn1 opened this issue Jan 21, 2024 · 61 comments
Closed

[BUG] Floating window does not show Peleton row targets #2026

k818mn1 opened this issue Jan 21, 2024 · 61 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@k818mn1
Copy link
k818mn1 commented Jan 21, 2024

Describe the bug
Connected to echelon rower and following a peleton row class. Peleton Target stroke rate (cadence) tile is enabled and displays correctly, but is not displayed on the floating window. Same is true for the peleton target pace.

To Reproduce
Steps to reproduce the behavior:
Does it all the time

Expected behavior
Display peleton target stroke rate next to actual stroke rate in the floating window. Display peleton target pace next to actual pace in the floating window.

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):

  • Device: Echelon tablet
  • OS: Android
  • Version QZ 2.16.0

Follow this guide https://github.com/cagnulein/qdomyos-zwift/wiki/How-do-i-get-the-debug-log-in-case-something-doesn't-work%3F

Additional context
Add any

@k818mn1 k818mn1 added the bug Something isn't working label Jan 21, 2024
@cagnulein
Copy link
Owner

don't you see the target cadence in the cadence row after the '/'?

@k818mn1
Copy link
Author
k818mn1 commented Jan 21, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 21, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 21, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 21, 2024 via email

@cagnulein
Copy link
Owner

@k818mn1 can you post a debug log with the issue. For the target pace you are right for sure, but the target cadence should be already in the floating window. Let me know!

@k818mn1
Copy link
Author
k818mn1 commented Jan 22, 2024

debug-Mon_Jan_22_11_09_50_2024.log
I updated the QZ app to the test version on Amazon appstore. Debug log uploaded. Target cadence is displayed on the tile but not in floating window. Pace and Target pace are displayed on the tiles but pace in floating window shows 'N/A' and target pace not displayed.

@cagnulein
Copy link
Owner
cagnulein commented Jan 22, 2024 via email

@cagnulein
Copy link
Owner

i just fixed the target cadence issue, but I can't find the issue on the pace. I also tried with the fake rower setting and the pace is populating well forcing a pace.

So let's try with the 2.16.38 version that I will upload it shortly and see if it makes any difference.
Thanks

@cagnulein
Copy link
Owner
cagnulein commented Jan 24, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

debug-Wed_Jan_24_09_41_53_2024.log
Target Cadence and Target Pace tiles are displayed but do not track the peleton class callouts reliably. Floating window Cadence and Target Cadence display same values as the tiles. Floating window Pace shows N/A with no Target pace. Gears tile value increments continously by 1 every second. Floating window Gears displays 0. Preset tiles function but set resistance to wrong value.

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

debug-Wed_Jan_24_09_47_10_2024.log
Another row class

@cagnulein
Copy link
Owner

debug-Wed_Jan_24_09_47_10_2024.log Another row class

in this log you have preset resistance 1 to 10 and preset 2 to 15

and here is working as they have

Wed Jan 24 09:56:18 2024 1706111778149 Debug: ../src/homeform.cpp void homeform::LargeButton(const QString &) "LargeButton" "preset_resistance_2"
Wed Jan 24 09:56:18 2024 1706111778224 Debug: ../src/echelonrower.cpp void echelonrower::update() "writing resistance 10"
Wed Jan 24 09:56:21 2024 1706111781619 Debug: ../src/homeform.cpp void homeform::LargeButton(const QString &) "LargeButton" "preset_resistance_2"
Wed Jan 24 09:56:23 2024 1706111783826 Debug: ../src/homeform.cpp void homeform::LargeButton(const QString &) "LargeButton" "preset_resistance_1"
Wed Jan 24 09:56:23 2024 1706111783839 Debug: ../src/echelonrower.cpp void echelonrower::update() "writing resistance 5"
Wed Jan 24 09:56:46 2024 1706111806913 Debug: ../src/homeform.cpp void homeform::LargeButton(const QString &) "LargeButton" "preset_resistance_2"
Wed Jan 24 09:56:47 2024 1706111807023 Debug: ../src/echelonrower.cpp void echelonrower::update() "writing resistance 10"

what are you seeing instead?

also i don't see anywhere the increments to 1 continuosly in the first and in the 2nd log neither.

could you please create a log with this issue?

@cagnulein
Copy link
Owner

i also checked the last log and the 18 rpm for the cadence is right with the peloton program.

  "target_metrics_performance_data":{
      "target_metrics":[
         {
            "metrics":[
               {
                  "lower":18,
                  "name":"stroke_rate",
                  "upper":22
               },
               {
                  "lower":0,
                  "name":"pace_intensity",
                  "upper":0
               }
            ],
            "offsets":{
               "end":107,
               "start":60
            },
            "segment_type":"caesar"

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

debug-Wed_Jan_24_10_27_47_2024.log
Preset issue. Buttons are preset to 10 and 15 but when pressed they set resistance to 5 and 10 respectively.

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024
20240124_102835.mp4

Video of Gears tile incrementing.

@cagnulein
Copy link
Owner

debug-Wed_Jan_24_10_27_47_2024.log Preset issue. Buttons are preset to 10 and 15 but when pressed they set resistance to 5 and 10 respectively.

that's because you have a gears value of -5

@cagnulein
Copy link
Owner

ok let me check if i can see this gear ghost too here

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

Target Cadence tile matches the peleton class initially but when the peleton class cadence changes the QZ tile does not change. Same for Target pace, it does not change when the peleton class instructor changes the intensity.

@cagnulein
Copy link
Owner

gears issue fixed!

Target Cadence tile matches the peleton class initially but when the peleton class cadence changes the QZ tile does not change. Same for Target pace, it does not change when the peleton class instructor changes the intensity.

did you collect this in one of the above log?

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

Yes, it will be in the 9:47 am log.

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

Digging into the Gears tile, when QZ is paused the + and - buttons on the Gears tile function correctly, changing the resistance by the Gears gain amount. But the number displayed on the Gears tile is always zero. When I press Start, the Gears number starts to increment by 1 per second continuously until I press Pause.

@cagnulein
Copy link
Owner

Yes, it will be in the 9:47 am log.

perfect, i will check it tomorrow. thanks

don't worry about the gear issue it was just a stupid copy and paste that leads to the random thing that you are seeing

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

I just did a different row class and the target cadence followed the class cadence very well. I had the Peleton app in full screen with the QZ floating window on top and Auto Sync enabled (this is how I usually use QZ). When I switched to split screen mode with Peleton on the left and QZ on the right then it lost sync and stopped following cadence changes. How does QZ sync, does it read the time on the screen?

@cagnulein
Copy link
Owner
cagnulein commented Jan 24, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 24, 2024

Yes, it is definitely the autosync that was causing the issue with syncing. I tried with manual sync and it tracked ok. I also tried with QZ running on my android phone and it tracked the changes well. So that's not an issue.

@k818mn1
Copy link
Author
k818mn1 commented Jan 26, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 26, 2024 via email

@cagnulein
Copy link
Owner

ok fixed but now there is a layout issue :)
Screenshot 2024-01-27 at 08 28 27

@cagnulein
Copy link
Owner
Screenshot 2024-01-27 at 08 35 38 are you ok with this when you have the target pace?

@k818mn1
Copy link
Author
k818mn1 commented Jan 27, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 27, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 28, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 28, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 28, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 28, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 30, 2024 via email

@k818mn1
Copy link
Author
k818mn1 commented Jan 30, 2024 via email

@cagnulein
Copy link
Owner

Great! Strange the speed is calculated from the pace. Which values do you see on the speed?
Peloton sends intensity and also speed and cadence if i remember correctly

@k818mn1
Copy link
Author
k818mn1 commented Jan 30, 2024 via email

@cagnulein
Copy link
Owner
cagnulein commented Jan 30, 2024 via email

@cagnulein
Copy link
Owner

I added a question here #1481 since I worked a lot on this topic in the last months. I don't want to break something (even if it's only the coloring).

@cagnulein
Copy link
Owner
cagnulein commented Jan 31, 2024 via email

Copy link
stale bot commented Feb 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Feb 16, 2024
@cagnulein
Copy link
Owner

@k818mn1 so can we close this?

@stale stale bot removed the wontfix This will not be worked on label Feb 16, 2024
@k818mn1
Copy link
Author
k818mn1 commented Feb 16, 2024 via email

@cagnulein cagnulein added this to the 2.16 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants