-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Floating window does not show Peleton row targets #2026
Comments
don't you see the target cadence in the cadence row after the '/'? |
No, only the actual cadence. Same for Pace, only the actual pace is displayed not the target.Target stroke rate from peleton and target pace are displayed in the relevant tiles, but not in the floating window.
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/21/24 1:33 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Author ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
don't you see the target cadence in the cadence row after the '/'?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
got the issue, I will do in the next versions.
note for me: templateinfosenderbuilder is the culprit
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 21 gen 2024 alle ore 21:16 k818mn1 ***@***.***>
ha scritto:
… No, only the actual cadence. Same for Pace, only the actual pace is
displayed not the target.Target stroke rate from peleton and target pace
are displayed in the relevant tiles, but not in the floating window.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/21/24 1:33 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Author ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
don't you see the target cadence in the cadence row after the '/'?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWHUFEU4CV2GFWZQF6TYPVZQRAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG42DQOBYHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
That's great, thanks. My tablet is currently on version 2.16.0 which I downloaded from Amazon appstore. It's not the latest version, when will it get updated?
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/21/24 2:18 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Author ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
got the issue, I will do in the next versions.
note for me: templateinfosenderbuilder is the culprit
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 21 gen 2024 alle ore 21:16 k818mn1 ***@***.***>
ha scritto:
No, only the actual cadence. Same for Pace, only the actual pace is
displayed not the target.Target stroke rate from peleton and target pace
are displayed in the relevant tiles, but not in the floating window.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/21/24 1:33 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Author ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
don't you see the target cadence in the cadence row after the '/'?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWHUFEU4CV2GFWZQF6TYPVZQRAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG42DQOBYHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
i will add you to the amazon beta tester then
send me an email to roberto.viola83 at gmail.com with your amazon email
account as a reminder. thanks
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 21 gen 2024 alle ore 21:33 k818mn1 ***@***.***>
ha scritto:
… That's great, thanks. My tablet is currently on version 2.16.0 which I
downloaded from Amazon appstore. It's not the latest version, when will it
get updated?
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/21/24 2:18 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Author ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
got the issue, I will do in the next versions.
note for me: templateinfosenderbuilder is the culprit
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 21 gen 2024 alle ore 21:16 k818mn1 ***@***.***>
ha scritto:
> No, only the actual cadence. Same for Pace, only the actual pace is
> displayed not the target.Target stroke rate from peleton and target pace
> are displayed in the relevant tiles, but not in the floating window.
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/21/24 1:33 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Author ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> don't you see the target cadence in the cadence row after the '/'?
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you authored the thread.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <
#2026 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAALYWHUFEU4CV2GFWZQF6TYPVZQRAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG42DQOBYHA
>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you authored the thread.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWBXN2JC4IBPJI43VPDYPV3SHAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBSG42TIMBXGQ>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
@k818mn1 can you post a debug log with the issue. For the target pace you are right for sure, but the target cadence should be already in the floating window. Let me know! |
debug-Mon_Jan_22_11_09_50_2024.log |
Thanks, I'll check it out!
Il giorno lun 22 gen 2024 alle 18:27 k818mn1 ***@***.***> ha
scritto:
… debug-Mon_Jan_22_11_09_50_2024.log
<https://github.com/cagnulein/qdomyos-zwift/files/14013394/debug-Mon_Jan_22_11_09_50_2024.log>
I updated the QZ app to the test version on Amazon appstore. Debug log
uploaded. Target cadence is displayed on the tile but not in floating
window. Pace and Target pace are displayed on the tiles but pace in
floating window shows 'N/A' and target pace not displayed.
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWATF3MZXUTT5N2LCR3YP2ORZAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQ3TIMZTHA>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
i just fixed the target cadence issue, but I can't find the issue on the pace. I also tried with the fake rower setting and the pace is populating well forcing a pace. So let's try with the 2.16.38 version that I will upload it shortly and see if it makes any difference. |
just submitted to the amazon app store the new beta
let me know!
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno lun 22 gen 2024 alle ore 18:50 cagnulein ***@***.***> ha
scritto:
… Thanks, I'll check it out!
Il giorno lun 22 gen 2024 alle 18:27 k818mn1 ***@***.***>
ha scritto:
> debug-Mon_Jan_22_11_09_50_2024.log
> <https://github.com/cagnulein/qdomyos-zwift/files/14013394/debug-Mon_Jan_22_11_09_50_2024.log>
> I updated the QZ app to the test version on Amazon appstore. Debug log
> uploaded. Target cadence is displayed on the tile but not in floating
> window. Pace and Target pace are displayed on the tiles but pace in
> floating window shows 'N/A' and target pace not displayed.
>
> —
> Reply to this email directly, view it on GitHub
> <#2026 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAALYWATF3MZXUTT5N2LCR3YP2ORZAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBUGQ3TIMZTHA>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
debug-Wed_Jan_24_09_41_53_2024.log |
debug-Wed_Jan_24_09_47_10_2024.log |
in this log you have preset resistance 1 to 10 and preset 2 to 15 and here is working as they have
what are you seeing instead? also i don't see anywhere the increments to 1 continuosly in the first and in the 2nd log neither. could you please create a log with this issue? |
i also checked the last log and the 18 rpm for the cadence is right with the peloton program.
|
debug-Wed_Jan_24_10_27_47_2024.log |
20240124_102835.mp4Video of Gears tile incrementing. |
that's because you have a gears value of -5 |
ok let me check if i can see this gear ghost too here |
Target Cadence tile matches the peleton class initially but when the peleton class cadence changes the QZ tile does not change. Same for Target pace, it does not change when the peleton class instructor changes the intensity. |
gears issue fixed!
did you collect this in one of the above log? |
Yes, it will be in the 9:47 am log. |
Digging into the Gears tile, when QZ is paused the + and - buttons on the Gears tile function correctly, changing the resistance by the Gears gain amount. But the number displayed on the Gears tile is always zero. When I press Start, the Gears number starts to increment by 1 per second continuously until I press Pause. |
perfect, i will check it tomorrow. thanks don't worry about the gear issue it was just a stupid copy and paste that leads to the random thing that you are seeing |
I just did a different row class and the target cadence followed the class cadence very well. I had the Peleton app in full screen with the QZ floating window on top and Auto Sync enabled (this is how I usually use QZ). When I switched to split screen mode with Peleton on the left and QZ on the right then it lost sync and stopped following cadence changes. How does QZ sync, does it read the time on the screen? |
yes it reads the time on screen with auto sync enabled. i suggest to
disable to check if it's the issue (could be, it mostly not used from
anyone)
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno mer 24 gen 2024 alle 20:00 k818mn1 ***@***.***> ha
scritto:
… I just did a different row class and the target cadence followed the class
cadence very well. I had the Peleton app in full screen with the QZ
floating window on top and Auto Sync enabled (this is how I usually use
QZ). When I switched to split screen mode with Peleton on the left and QZ
on the right then it lost sync and stopped following cadence changes. How
does QZ sync, does it read the time on the screen?
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWA2GCZ5APMJA36TVEDYQFK4FAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBYG42DENBYGI>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
Yes, it is definitely the autosync that was causing the issue with syncing. I tried with manual sync and it tracked ok. I also tried with QZ running on my android phone and it tracked the changes well. So that's not an issue. |
Let me know when the new version is available on Amazon appstore, please.
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/26/24 9:41 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
but it should just display the regular pace not N/A
anyway i'm committing it
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno ven 26 gen 2024 alle ore 16:39 cagnulein ***@***.***> ha
scritto:
you're right! i'm fixing it!
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno ven 26 gen 2024 alle ore 16:36 k818mn1 ***@***.***>
ha scritto:
> I see target_pace_s, target_pace_m and target_pace_h, which are the
> values displayed in the text string, but not target_pace, which is tested
> by the if condition.
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/26/24 9:08 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
>
> In templateinfosenderbuilder.cpp do we need to add target_pace and
> target_speed for tp == bluetoothdevice::ROWING? I can only see
> target_cadence in the list of signals for Rowing.
>
> target pace is already here
>
> https://github.com/cagnulein/qdomyos-zwift/blob/84c351e55c0b4eb5940301b4d597fd4e8e3fe478/src/templateinfosenderbuilder.cpp#L1093
> i'm adding target speed, but for the pace it's not the issue
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <#2026 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAALYWFXTME6EL6KHZFSUTLYQPEPDAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGI3DGMRYGA>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Sure, I will try in the weekend
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno ven 26 gen 2024 alle 18:17 k818mn1 ***@***.***> ha
scritto:
… Let me know when the new version is available on Amazon appstore, please.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/26/24 9:41 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
but it should just display the regular pace not N/A
anyway i'm committing it
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno ven 26 gen 2024 alle ore 16:39 cagnulein ***@***.***> ha
scritto:
> you're right! i'm fixing it!
>
> Roberto Viola
> Software engineer and open source enthusiast
> http://robertoviola.cloud
>
>
>
> Il giorno ven 26 gen 2024 alle ore 16:36 k818mn1 ***@***.***>
> ha scritto:
>
>> I see target_pace_s, target_pace_m and target_pace_h, which are the
>> values displayed in the text string, but not target_pace, which is
tested
>> by the if condition.
>> -------- Original message --------From: Roberto Viola ***@***.***> Date:
>> 1/26/24 9:08 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
>> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
>> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton
row
>> targets (Issue #2026)
>>
>> In templateinfosenderbuilder.cpp do we need to add target_pace and
>> target_speed for tp == bluetoothdevice::ROWING? I can only see
>> target_cadence in the list of signals for Rowing.
>>
>> target pace is already here
>>
>>
https://github.com/cagnulein/qdomyos-zwift/blob/84c351e55c0b4eb5940301b4d597fd4e8e3fe478/src/templateinfosenderbuilder.cpp#L1093
>> i'm adding target speed, but for the pace it's not the issue
>>
>> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
>> receiving this because you were mentioned.Message ID: ***@***.***>
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <
#2026 (comment)
>,
>> or unsubscribe
>> <
https://github.com/notifications/unsubscribe-auth/AAALYWFXTME6EL6KHZFSUTLYQPEPDAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGI3DGMRYGA
>
>> .
>> You are receiving this because you were assigned.Message ID:
>> ***@***.***>
>>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWFVSIN6KSW7ORWH55LYQPQJLAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJSGQYDMNZVHE>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I would prefer one line without leading zeroes, eg 2:15:/2:45 if the window could be made a little wider.If that's too difficult then 2 lines is OK.Does it change color like the cadence?
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
Screenshot.2024-01-27.at.08.35.38.png (view on web)
are you ok with this when you have the target pace?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
yes i already removed the leading 0. i can't make it wider, people already
complaints about the fact that it's too wide :D
nope i don't set the color. i will do and i will push to amazon app store
beta in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
scritto:
… I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
window could be made a little wider.If that's too difficult then 2 lines is
OK.Does it change color like the cadence?
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
Screenshot.2024-01-27.at.08.35.38.png (view on web)
are you ok with this when you have the target pace?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I think you will have the same problem when displaying speed/target speed. For example 11.3/12.2 is 9 characters.
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/27/24 10:13 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
yes i already removed the leading 0. i can't make it wider, people already
complaints about the fact that it's too wide :D
nope i don't set the color. i will do and i will push to amazon app store
beta in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
scritto:
I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
window could be made a little wider.If that's too difficult then 2 lines is
OK.Does it change color like the cadence?
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
Screenshot.2024-01-27.at.08.35.38.png (view on web)
are you ok with this when you have the target pace?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
yes that's why 2 lines are better
or another idea is to removing avg and max when there is a target pace
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle 02:29 k818mn1 ***@***.***> ha
scritto:
… I think you will have the same problem when displaying speed/target speed.
For example 11.3/12.2 is 9 characters.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/27/24 10:13 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
yes i already removed the leading 0. i can't make it wider, people already
complaints about the fact that it's too wide :D
nope i don't set the color. i will do and i will push to amazon app store
beta in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
scritto:
> I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
> window could be made a little wider.If that's too difficult then 2 lines
is
> OK.Does it change color like the cadence?
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> Screenshot.2024-01-27.at.08.35.38.png (view on web)
> are you ok with this when you have the target pace?
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <
#2026 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY
>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWE3OF4FWTAAPZL5CALYQWSY5AVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQYDCMJYGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I think that is a better idea. They aren't relevant and I can't even read average or max because the font is too small for my eyes.
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/28/24 12:51 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
yes that's why 2 lines are better
or another idea is to removing avg and max when there is a target pace
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle 02:29 k818mn1 ***@***.***> ha
scritto:
I think you will have the same problem when displaying speed/target speed.
For example 11.3/12.2 is 9 characters.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/27/24 10:13 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
yes i already removed the leading 0. i can't make it wider, people already
complaints about the fact that it's too wide :D
nope i don't set the color. i will do and i will push to amazon app store
beta in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
scritto:
> I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
> window could be made a little wider.If that's too difficult then 2 lines
is
> OK.Does it change color like the cadence?
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> Screenshot.2024-01-27.at.08.35.38.png (view on web)
> are you ok with this when you have the target pace?
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <
#2026 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY
>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWE3OF4FWTAAPZL5CALYQWSY5AVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQYDCMJYGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ok i will try to do this tomorrow
there was already an idea to remove the avg and max for all the lines.
anyway let's do this first
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle 14:06 k818mn1 ***@***.***> ha
scritto:
… I think that is a better idea. They aren't relevant and I can't even read
average or max because the font is too small for my eyes.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/28/24 12:51 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
yes that's why 2 lines are better
or another idea is to removing avg and max when there is a target pace
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle 02:29 k818mn1 ***@***.***> ha
scritto:
> I think you will have the same problem when displaying speed/target
speed.
> For example 11.3/12.2 is 9 characters.
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/27/24 10:13 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> yes i already removed the leading 0. i can't make it wider, people
already
>
> complaints about the fact that it's too wide :D
>
>
>
> nope i don't set the color. i will do and i will push to amazon app store
>
> beta in the next days
>
>
>
> Roberto Viola
>
> Software engineer and open source enthusiast
>
> http://robertoviola.cloud
>
>
>
>
>
>
>
> Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
>
> scritto:
>
>
>
> > I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
>
> > window could be made a little wider.If that's too difficult then 2
lines
> is
>
> > OK.Does it change color like the cadence?
>
> > -------- Original message --------From: Roberto Viola ***@***.***>
Date:
>
> > 1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***>
Cc:
>
> > k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
>
> > [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton
row
>
> > targets (Issue #2026)
>
> > Screenshot.2024-01-27.at.08.35.38.png (view on web)
>
> > are you ok with this when you have the target pace?
>
> >
>
> > —Reply to this email directly, view it on GitHub, or unsubscribe.You
are
>
> > receiving this because you were mentioned.Message ID: ***@***.***>
>
> >
>
> > —
>
> > Reply to this email directly, view it on GitHub
>
> > <
>
#2026 (comment)
> >,
>
> > or unsubscribe
>
> > <
>
https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY
> >
>
> > .
>
> > You are receiving this because you were assigned.Message ID:
>
> > ***@***.***>
>
> >
>
>
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <
#2026 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AAALYWE3OF4FWTAAPZL5CALYQWSY5AVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQYDCMJYGM
>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWH7ZVP6EJD27Y6NMXLYQZELXAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU4TAMZYG4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
done! color and pace row fixed! i'm sending it to the amazon beta
let me know!
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle ore 14:16 cagnulein ***@***.***> ha
scritto:
… ok i will try to do this tomorrow
there was already an idea to remove the avg and max for all the lines.
anyway let's do this first
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno dom 28 gen 2024 alle 14:06 k818mn1 ***@***.***>
ha scritto:
> I think that is a better idea. They aren't relevant and I can't even
> read average or max because the font is too small for my eyes.
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/28/24 12:51 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> yes that's why 2 lines are better
>
> or another idea is to removing avg and max when there is a target pace
>
>
>
> Roberto Viola
>
> Software engineer and open source enthusiast
>
> http://robertoviola.cloud
>
>
>
>
>
>
>
> Il giorno dom 28 gen 2024 alle 02:29 k818mn1 ***@***.***> ha
>
> scritto:
>
>
>
> > I think you will have the same problem when displaying speed/target
> speed.
>
> > For example 11.3/12.2 is 9 characters.
>
> > -------- Original message --------From: Roberto Viola ***@***.***> Date:
>
> > 1/27/24 10:13 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***>
> Cc:
>
> > k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
>
> > [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton
> row
>
> > targets (Issue #2026)
>
> > yes i already removed the leading 0. i can't make it wider, people
> already
>
> >
>
> > complaints about the fact that it's too wide :D
>
> >
>
> >
>
> >
>
> > nope i don't set the color. i will do and i will push to amazon app
> store
>
> >
>
> > beta in the next days
>
> >
>
> >
>
> >
>
> > Roberto Viola
>
> >
>
> > Software engineer and open source enthusiast
>
> >
>
> > http://robertoviola.cloud
>
> >
>
> >
>
> >
>
> >
>
> >
>
> >
>
> >
>
> > Il giorno sab 27 gen 2024 alle 16:13 k818mn1 ***@***.***> ha
>
> >
>
> > scritto:
>
> >
>
> >
>
> >
>
> > > I would prefer one line without leading zeroes, eg 2:15:/2:45 if the
>
> >
>
> > > window could be made a little wider.If that's too difficult then 2
> lines
>
> > is
>
> >
>
> > > OK.Does it change color like the cadence?
>
> >
>
> > > -------- Original message --------From: Roberto Viola ***@***.***>
> Date:
>
> >
>
> > > 1/27/24 1:36 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***>
> Cc:
>
> >
>
> > > k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
>
> >
>
> > > [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton
> row
>
> >
>
> > > targets (Issue #2026)
>
> >
>
> > > Screenshot.2024-01-27.at.08.35.38.png (view on web)
>
> >
>
> > > are you ok with this when you have the target pace?
>
> >
>
> > >
>
> >
>
> > > —Reply to this email directly, view it on GitHub, or unsubscribe.You
> are
>
> >
>
> > > receiving this because you were mentioned.Message ID: ***@***.***>
>
> >
>
> > >
>
> >
>
> > > —
>
> >
>
> > > Reply to this email directly, view it on GitHub
>
> >
>
> > > <
>
> >
> #2026 (comment)
>
> > >,
>
> >
>
> > > or unsubscribe
>
> >
>
> > > <
>
> >
> https://github.com/notifications/unsubscribe-auth/AAALYWCJRCZWSTU4EXTI2XTYQUKQJAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGE4DGMZVGY
>
> > >
>
> >
>
> > > .
>
> >
>
> > > You are receiving this because you were assigned.Message ID:
>
> >
>
> > > ***@***.***>
>
> >
>
> > >
>
> >
>
> >
>
> >
>
> > —Reply to this email directly, view it on GitHub, or unsubscribe.You are
>
> > receiving this because you were mentioned.Message ID: ***@***.***>
>
> >
>
> > —
>
> > Reply to this email directly, view it on GitHub
>
> > <
> #2026 (comment)
> >,
>
> > or unsubscribe
>
> > <
> https://github.com/notifications/unsubscribe-auth/AAALYWE3OF4FWTAAPZL5CALYQWSY5AVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGQYDCMJYGM
> >
>
> > .
>
> > You are receiving this because you were assigned.Message ID:
>
> > ***@***.***>
>
> >
>
>
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <#2026 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAALYWH7ZVP6EJD27Y6NMXLYQZELXAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJTGU4TAMZYG4>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
It's great! Pace and Target pace display correctly and change color as they should. I don't miss displaying the averages. The problem with always displaying N/A is fixed, I think it was a precedence issue due to target_pace being undefined.Cadence and target cadence already worked in the previous version.Speed and target speed still need some work. However, I don't think target speed is really necessary if target pace is displayed. I assume QZ calculates target speed from target pace, so they are really the same information? What metrics actually come from peleton, just cadence and intensity?
|
Great! Strange the speed is calculated from the pace. Which values do you see on the speed? |
Speed and speed target display the correct values, but don't change color. And they are too many digits to fit.
-------- Original message --------From: Roberto Viola ***@***.***> Date: 1/30/24 9:50 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
Great! Strange the speed is calculated from the pace. Which values do you see on the speed?
Peloton sends intensity and also speed and cadence if i remember correctly
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Ok so I will adopt the same patch of the pace
I will try to do in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno mar 30 gen 2024 alle 18:27 k818mn1 ***@***.***> ha
scritto:
… Speed and speed target display the correct values, but don't change color.
And they are too many digits to fit.
-------- Original message --------From: Roberto Viola ***@***.***> Date:
1/30/24 9:50 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
[cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
targets (Issue #2026)
Great! Strange the speed is calculated from the pace. Which values do you
see on the speed?
Peloton sends intensity and also speed and cadence if i remember correctly
—Reply to this email directly, view it on GitHub, or unsubscribe.You are
receiving this because you were mentioned.Message ID: ***@***.***>
—
Reply to this email directly, view it on GitHub
<#2026 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAALYWB5HI3IKQDRYAXXSULYREUPZAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGU2DEMBXGM>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
I added a question here #1481 since I worked a lot on this topic in the last months. I don't want to break something (even if it's only the coloring). |
In the meantime I'm removing avg speed and max speed when the target speed
is set
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno mar 30 gen 2024 alle ore 18:29 cagnulein ***@***.***> ha
scritto:
… Ok so I will adopt the same patch of the pace
I will try to do in the next days
Roberto Viola
Software engineer and open source enthusiast
http://robertoviola.cloud
Il giorno mar 30 gen 2024 alle 18:27 k818mn1 ***@***.***>
ha scritto:
> Speed and speed target display the correct values, but don't change
> color. And they are too many digits to fit.
> -------- Original message --------From: Roberto Viola ***@***.***> Date:
> 1/30/24 9:50 AM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc:
> k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re:
> [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row
> targets (Issue #2026)
> Great! Strange the speed is calculated from the pace. Which values do you
> see on the speed?
> Peloton sends intensity and also speed and cadence if i remember correctly
>
> —Reply to this email directly, view it on GitHub, or unsubscribe.You are
> receiving this because you were mentioned.Message ID: ***@***.***>
>
> —
> Reply to this email directly, view it on GitHub
> <#2026 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAALYWB5HI3IKQDRYAXXSULYREUPZAVCNFSM6AAAAABCEGE7OOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJXGU2DEMBXGM>
> .
> You are receiving this because you were assigned.Message ID:
> ***@***.***>
>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
@k818mn1 so can we close this? |
Yes, it works great for me thanks
-------- Original message --------From: Roberto Viola ***@***.***> Date: 2/15/24 9:32 PM (GMT-06:00) To: cagnulein/qdomyos-zwift ***@***.***> Cc: k818mn1 ***@***.***>, Mention ***@***.***> Subject: Re: [cagnulein/qdomyos-zwift] [BUG] Floating window does not show Peleton row targets (Issue #2026)
@k818mn1 so can we close this?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Describe the bug
Connected to echelon rower and following a peleton row class. Peleton Target stroke rate (cadence) tile is enabled and displays correctly, but is not displayed on the floating window. Same is true for the peleton target pace.
To Reproduce
Steps to reproduce the behavior:
Does it all the time
Expected behavior
Display peleton target stroke rate next to actual stroke rate in the floating window. Display peleton target pace next to actual pace in the floating window.
Screenshots
If applicable, add screenshots to help explain your problem.
Smartphone (please complete the following information):
Follow this guide https://github.com/cagnulein/qdomyos-zwift/wiki/How-do-i-get-the-debug-log-in-case-something-doesn't-work%3F
Additional context
Add any
The text was updated successfully, but these errors were encountered: