[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Proper RTL support #434

Closed
wants to merge 13 commits into from
Closed

Fix: Proper RTL support #434

wants to merge 13 commits into from

Conversation

iyadthayyil
Copy link
Contributor
@iyadthayyil iyadthayyil commented Jun 28, 2018 •
edited
Loading

TODO

  • BottomNavigation
  • Button
  • Caption
  • Card
  • CardActions
  • CardContent
  • CardCover
  • Checkbox
  • Chip
  • Dialog
  • DialogActions
  • DialogContent
  • DialogScrollArea
  • DialogTitle
  • Divider
  • DrawerItem
  • DrawerSection
  • FAB
  • FABGroup
  • Headline
  • HelperText
  • ListAccordion
  • ListItem
  • ListSection
  • Modal
  • Paper
  • Paragraph
  • ProgressBar
  • RadioButton
  • RadioButtonGroup
  • Searchbar
  • Snackbar
  • Subheading
  • Switch
  • Text
  • TextInput
  • Title
  • Appbar
  • AppbarAction
  • AppbarBackAction
  • AppbarContent
  • TouchableRipple
  • Icons

fixes #375

@callstack-bot
Copy link
callstack-bot commented Jun 28, 2018 •
edited
Loading

Hey @iyadthayyil, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

satya164
satya164 requested changes Jun 28, 2018
View reviewed changes
Copy link
Member
@satya164 satya164 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @iyadthayyil! Thanks so much for the pull request. This is really awesome!

Regarding the approach, I think rtl support should be automatic without having to provide an iconRtl prop. The Icon component should flip itself if we detect RTL.

Is there any case where this behavior is not desirable?

If it's really a necessity, I think a better approach will be to add rtl: boolean to the theme.

Please join our discord if you wanna chat: https://discord.gg/zwR2Cdh

@ferrannp
Copy link
Collaborator

@iyadthayyil are you still working on this? This is quite important for v2.

@ferrannp ferrannp added the wip label Jul 19, 2018
@iyadthayyil
Copy link
Contributor Author

@ferrannp Most components are already RTL supported, except few like texts, icons, textInput and searchBar.
Me and @waquidvp fixed some of them, we are waiting for new textInput pull request to be merged to work on it, also I have some questions about searchBar styling for RTL

@iyadthayyil
Copy link
Contributor Author

@satya164 I have fixed RTL support of icons as you requested, but some tests are failing can you take a look on it please.

@satya164
Copy link
Member

@iyadthayyil awesome. to update the snapshot tests you can run yarn test -u and to fix the eslint errors, you can run yarn lint --fix

@ferrannp
Copy link
Collaborator

It looks like we still have some Flow errors.

@defint
Copy link
defint commented Jul 26, 2018

Hello!
First of all we are very happy to use your library, it's cool, well documented and really reduces amount of our headache. We are currently in the process of development one production application and recently we ran into one problem with arabic language support for input fields.

We know that you are in the process of fixing it, but due to our time constraints it's really important for us to know at least approximate schedule for fixing this problem. So we can make a decision whether it would be better just to wait for your fixes, or to fork and try to support it on our own. So, could you please give us approximate amount of time you are planning to spend on fixes, if it wouldn't bother you much?

Looking forward for your answers and thank you for your work.

Regards,
Avalanche Laboratory developers

@satya164
Copy link
Member

@defint Hey, we can't provide a timeline yet. I'd suggest forking it for now and maybe send a pull request :D

Also, it'll better if you wait till #429 is merged before you fork :)

@ferrannp
Copy link
Collaborator

@iyadthayyil do you need any help to land this?

@ferrannp ferrannp mentioned this pull request Jul 27, 2018
Closed
@iyadthayyil
Copy link
Contributor Author

I have no idea about the errors, @satya164 @ferrannp your help is highly appreciated.

@satya164
Copy link
Member
satya164 commented Aug 4, 2018

I'll check it soon when I get some time.

satya164 pushed a commit that referenced this pull request Aug 8, 2018
@iyadthayyil @satya164
feat: RTL support. closes #434, #375
205be7b
@satya164 satya164 closed this Aug 8, 2018
satya164 pushed a commit that referenced this pull request Aug 8, 2018
@iyadthayyil @satya164
feat: RTL support. closes #434, #375
e49ba4e
jaulz pushed a commit to jaulz/react-native-paper that referenced this pull request Sep 7, 2018
@iyadthayyil
feat: RTL support. closes callstack#434, callstack#375
c7eba22
eriveltonelias pushed a commit to eriveltonelias/react-native-paper that referenced this pull request Sep 21, 2018
@iyadthayyil @eriveltonelias
feat: RTL support. closes callstack#434, callstack#375
cac5b49
@samhoseinkhani
Copy link

after all these changes how we can make lists RTL ?

@masoud-msk
Copy link

Does TextInput support RTL?

@Trancever
Copy link
Contributor

@masoud-msk Yes, it does

@mtn1988
Copy link
mtn1988 commented Apr 15, 2019 •
edited
Loading

@Trancever
After updating React Native from 0.58.6 to 0.59.4, TextInput doesn't support RTL anymore!!
My react-native-paper version is 2.15.2

@meliodev
Copy link
meliodev commented Jan 2, 2021

RTL is not working for TextInput. I tested on Android.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satya164 satya164 satya164 requested changes

Assignees
No one assigned
Labels
high priority wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet