[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrap overflowing menu in scrollView #1084

Merged
merged 2 commits into from
Sep 9, 2019
Merged

fix: wrap overflowing menu in scrollView #1084

merged 2 commits into from
Sep 9, 2019

Conversation

iyadthayyil
Copy link
Contributor

Motivation

fixes #1075

Test plan

@callstack-bot
Copy link
callstack-bot commented May 23, 2019 •
edited
Loading

Hey @iyadthayyil, thank you for your pull request 🤗. The documentation from this branch can be viewed here.

@Trancever Trancever closed this Jun 3, 2019
@Trancever Trancever reopened this Jun 3, 2019
@iyadthayyil iyadthayyil force-pushed the fix/scrollable-menu branch 6 times, most recently from 522943f to 77d6b1b Compare June 6, 2019 15:39
@jayu jayu merged commit fa22a68 into callstack:master Sep 9, 2019
@jayu
Copy link
Contributor
jayu commented Sep 9, 2019

Thanks for the PR @iyadthayyil! Sorry for such a long delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayu jayu jayu approved these changes

@Trancever Trancever Awaiting requested review from Trancever

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Menu goes outside of screen when many items are present
4 participants
@iyadthayyil @callstack-bot @jayu @Trancever