[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix for dumping dbc with objects whose names have been shortened #182

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Bugfix for dumping dbc with objects whose names have been shortened #182

merged 2 commits into from
Jan 25, 2020

Conversation

geo4711
Copy link
Contributor
@geo4711 geo4711 commented Jan 24, 2020

Objects (messages, signals, nodes) with an original name >32 chars and a modified name <= 32 chars are now dumped correctly.

@coveralls
Copy link
coveralls commented Jan 24, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.006%) to 96.597% when pulling c195d1d on geo4711:fix_long_names_modifications into fd56041 on eerimoq:master.

eerimoq
eerimoq reviewed Jan 25, 2020
View reviewed changes
Copy link
Collaborator
@eerimoq eerimoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can accept this for now, but long term node, message and signal attributes should be popped from the attributes dict when loading the DBC, and automatically be added to the DBC when dumping.

@eerimoq eerimoq merged commit dba3049 into cantools:master Jan 25, 2020
@eerimoq
Copy link
Collaborator
eerimoq commented Jan 25, 2020

Released to PyPI in version 33.1.1.

VonSquiggles pushed a commit to VonSquiggles/cantools that referenced this pull request May 13, 2022
@af-silva
Merge pull request cantools#182 from allesblinkt/master
0b167bf 
Fix missing `self.` for checking state change in p402.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eerimoq eerimoq eerimoq left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@geo4711 @coveralls @eerimoq