Arxml namespace improvements #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Will merge once the tests pass. |
The most significant change implied by this is probably that the AUTOSAR version is now parsed properly. This is done using some regular expressions on the namespace of the ElementTree root node. Maybe there's a better way to do it, but I'm not aware of any.
Actually, this logic can be used to compare any version scheme that roughly follows the semantic versioning specification.
e3adb0d
to
f37bfc5
Compare
|
Thanks for merging. The coveralls result is weird: if I see this correctly, it says that the coverage of the |
|
Yeah don't look too closely at it. It's weird sometimes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the quest for ARXML-3 support, cf https://github.com/andlaus/cantools/tree/arxml_refactor
In this PR, the XML namespace handling for ARXML files is improved and a method to conveniently compare AUTOSAR versions in the code is introduced.
Andreas Lauser andreas.lauser@mbition.io, Mercedes-Benz AG on behalf of MBition GmbH.
Imprint