Miscellaneous fixes for the ARXML code #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the coveralls result seems to exhibit the usual weirdness: overall coverage decrease with no decrease in any individual file.. |
eerimoq
reviewed
Dec 1, 2020
Side note: Adapting ARXML files manually is a lot of fun...
they do not change anything semantically but they make debugging much easier, in particular given the fact that the short names of many tags are not unique.
f690d7e
to
7d48d90
Compare
VonSquiggles
pushed a commit
to VonSquiggles/cantools
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR continues the quest for ARXML-3 support, cf https://github.com/andlaus/cantools/tree/arxml_refactor
We are getting closer to the wrap up: These are small unrelated issues I've stumbled over while hacking on the ARXML parser: The first patch makes all floating point types signed (because IEEE754 types are always signed), the second patch recognizes more encodings for integers because ARXML also supports non-two complement encodings (actually decoding the CAN frames is left for another day, though) and in the last patch, I've added UUID attributes to the
system-4.2.arxmlfile to aid debugging.Andreas Lauser andreas.lauser@mbition.io, Mercedes-Benz AG on behalf of MBition GmbH.
Imprint