[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ARXML version 3 #262

Merged
merged 2 commits into from
Feb 1, 2021
Merged

Conversation

andlaus
Copy link
Member
@andlaus andlaus commented Feb 1, 2021

At last, this pull request adds support for AUTOSAR3. Most changes are pretty minor, e.g., the top level packages need special treatment in AR3, but there also are a few exceptions; most notably is probably the way how the initial signal values are determined.

Besides this, this PR adds support for the XML namespace which Daimler uses for its ARXML3 files.

Andreas Lauser andreas.lauser@mbition.io, Mercedes-Benz AG on behalf of MBition GmbH.

Imprint

some tags are shuffled around compared to AUTOSAR4, but a some pieces
-- like specifying initial signal values -- require significantly more
work...
@coveralls
Copy link

Coverage Status

Coverage increased (+1.06%) to 97.044% when pulling 7f088f3 on Daimler:arxml3 into 7a1c31a on eerimoq:master.

@andlaus
Copy link
Member Author
andlaus commented Feb 1, 2021

as usual, the coverall summary results seem to be wrong: coverage of arxml.py only increases by 0.15% and other files are unaffected.

edit: maybe not: test_database.py gets a few additional lines...

@eerimoq
Copy link
Collaborator
eerimoq commented Feb 1, 2021

Thanks, merging.

@eerimoq eerimoq merged commit 03b1a3c into cantools:master Feb 1, 2021
@andlaus andlaus deleted the arxml3 branch December 11, 2021 08:09
VonSquiggles pushed a commit to VonSquiggles/cantools that referenced this pull request May 13, 2022
…antools#262)

* ds402: Remove set_new_home functionality from BaseNode402.homing().

The homing() method will try to manipulate the Home Offset (0x607C)
parameter by default.  That's not the way the parameter is intended to
work.  After a successful homing procedure, the drive should set the
Actual Position (0x6063) to the Home Offset (0x607C) by itself.  By
default that is zero, so the selected reference switch flank will mark
the new zero position.

The library's default behavior here is backwards, and can only work
with absolute position encoders.  The whole point of homing is to find
a physical reference and align the logical coordinate system to it.
Trying to determine the desired offset from the value which an
unreferenced encoder had at the physical reference point actually
destroys that logical alignment.

The functionality of set_new_home=True is trivial to do from the
application, so remove it completely from homing().

* ds402: Restore operation mode after homing only on explicit request.

Add a new parameter restore_op_mode which defaults to False, and skip
changing back to the previous mode unless it is explicitly enabled by
passing True.  Note that most applications will decide on the needed
mode after homing and therefore do not need this behavior, hence the
new default.

Co-authored-by: André Filipe Silva <af-silva@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants