Adds "plot" extra in setup.py #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This declares the optional dependency to matplotlib
Side note: The installation command example at the top seems to be an exception, for clarity most likely.
|
I guess time will tell. Those interested on maintaining the project should decide how to handle PR:s and releasing. |
|
Alright, will wait a bit to see if things move. Otherwise I will just merge and release by myself. |
VonSquiggles
pushed a commit
to VonSquiggles/cantools
that referenced
this pull request
May 13, 2022
…antools#279) Inside an EDS file's [Comments] section, the Lines attribute may be expressed as a hexadecimal number prefixed with 0x. The ConfigParser.getint() method however does not support such a format. Switch to the default int() constructor with a base=0 argument to enable auto-detection of this condition. The same is done for basically every other numeric value in the EDS importer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This declares the optional dependency to matplotlib.
In relation with #259, #260 and #265.
@eerimoq, I don't know what process you would like the contributors to follow when they author commit themselves. So for now I just make PR for review by other maintainers.