ARXML: allow to specify non-base 10 integer numbers #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in essence, this means replacing `int(my_string_value)` by `int(my_string_value, 0)`. For some reason python does not recognize numbers that start with a 0 and continue with a digit as octal, but AUTOSAR does, so this case needs to be handled as a special case. Signed-off-by: Andreas Lauser <andreas.lauser@mbition.io> Signed-off-by: Oliver Kopp <oliver.kopp@mbition.io>
VonSquiggles
pushed a commit
to VonSquiggles/cantools
that referenced
this pull request
May 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in essence, this means replacing
int(my_string_value)byint(my_string_value, 0). For some reason, python does not recognize numbers that start with a 0 and continue with a digit as octal, but AUTOSAR does, so this needs to be handled as a special case.note that with this patch, python's "0o" prefix for octal numbers is also recognized. As far as I know, AUTOSAR does not allow that, but as long as we properly recognize everything which AUTOSAR specifies, I don't see a big problem with that...
Andreas Lauser andreas.lauser@mbition.io, Mercedes-Benz AG on behalf of MBition GmbH.
Imprint