Add --with-comments option to dump #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andlaus
reviewed
Feb 25, 2021
andlaus
reviewed
Mar 1, 2021
| if with_comments: | ||
| com = [] | ||
| if siginst.comment: | ||
| com.append(siginst.comment) |
There was a problem hiding this comment.
I just noticed this: the ARXML file format supports multi-lingual comments, so the canonical way to access the comments is the .comments attribute of messages/signals. (which is a language string -> comment string dictionary. .comment is just the first entry of this dictionary.) If you don't consider it worthwhile to support such an exotic feature, I think this PR should go in as-is.
There was a problem hiding this comment.
Sounds like an additional PR to support that. I will keep it in the back of my head though :) Thanks for your review effort!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option to include signal comments and units in the database dump output.