ceph.spec.in: move specific BuildRequires to where they belong #4880
Conversation
BuildRequires: libbz2-devel is already in the suse section so line 60 is indeed a duplicate. BuildRequires: bzip2-devel is moved to the non suse section and the zip2 devel lib dedicated if/else/endif can be removed. Requires: gdisk BuildRequires: nss-devel BuildRequires: keyutils-libs-devel BuildRequires: libatomic_ops-devel Requires: gdisk gdisk is indeed a duplicate that can be removed. Reviewed-by: Loic Dachary <ldachary@redhat.com> |
50e4528
to
e1cb7e5
Compare
|
@smithfarm the Reviewed-by: will be added to the merge commit (it does not hurt to have it in the commit message but that's not a requirement). When I add a Reviewed-by: line to the comment, it means that Ken, who is assigned the pull request, may copy/paste it into the merge commit message to ack that I reviewed it. It's essentially the same as 👍 or LGTM, only it makes it easier for the person who merge and reduces the chances of a typo. |
|
interesting (but completely unrelated make check failure) |
|
@dachary: thanks for the |
|
I find |
ceph.spec.in: move specific BuildRequires to where they belong Reviewed-by: Loic Dachary <ldachary@redhat.com> Reviewed-by: Ken Dreyer <kdreyer@redhat.com>
|
That's fine too! :) |
Move distro-specific BuildRequires out of "common" section and into the appropriate %if statement in the "specific" section. Also remove a duplicated "Requires: gdisk". Signed-off-by: Nathan Cutler <ncutler@suse.com>
e1cb7e5
to
9bd678c
Compare
|
@ktdreyer rebased to current master |
|
I'd already pushed the older commit to the gitbuilders in order to verify it; hope you don't mind. Merged as 142a6ce |
|
No problem. |
Move distro-specific BuildRequires out of "common" section and
into the appropriate %if statement in the "specific" section.
Also remove a duplicated "Requires: gdisk".
Signed-off-by: Nathan Cutler ncutler@suse.com