[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] ceph.spec.in:BuildRequires keyutils-devel #4897

Closed
wants to merge 1 commit into from

Conversation

osynge
Copy link
@osynge osynge commented Jun 8, 2015

Move keyutils-devel to common area to fix fedora /suse build.

Signed-off-by: Owen Synge osynge@suse.com

@osynge
Copy link
Author
osynge commented Jun 8, 2015

@ghost
Copy link
ghost commented Jun 8, 2015

IIRC @smithfarm has a pull request in the same area

@ghost ghost assigned smithfarm Jun 8, 2015
@smithfarm
Copy link
Contributor

@osynge According to http://rpm.pbone.net/, keyutils-libs-devel appears to be the right name in Fedora and RH/CentOS. These are the relevant files it provides:

/usr/include/keyutils.h
/usr/lib64/libkeyutils.so

on openSUSE those same files are provided by keyutils-devel

@smithfarm
Copy link
Contributor

@osynge oh, and I forgot to add that keyutils-devel doesn't return anything on http://rpm.pbone.net/ which would seem to indicate that putting it in the "common" section is not a good idea.

@osynge
Copy link
Author
osynge commented Jun 8, 2015

@smithfarm Duplicating it for suse and for redhat name of the rpm ? I prefure this solution, where I move it once.

@smithfarm
Copy link
Contributor

@osynge what I was trying to say was that the package name keyutils-devel appears to be SUSE-specific. Are you sure redhat/centos/fedora has a package with this name?

@osynge
Copy link
Author
osynge commented Jun 9, 2015

@smithfarm keyutils-devel does look like a suse only. looking at https://build.opensuse.org/project/monitor/home:osynge:ceph:wip:wip_obs_fedora but I will give that some more time to schedule things.

But am expecting to redo this pull request.

@osynge
Copy link
Author
osynge commented Jun 10, 2015

This patch needs some more work, now we have found the issue please delay looking at this patch until further work is done.

@osynge
Copy link
Author
osynge commented Jun 10, 2015

This page will show success for this pull request at a later date.

https://build.opensuse.org/project/monitor/home:osynge:ceph:wip:wip_obs_fedora

@ktdreyer
Copy link
Member

You can retitle the Pull Request "[DNM]" in the mean time

@osynge osynge changed the title ceph.spec.in:BuildRequires keyutils-devel [DNM] ceph.spec.in:BuildRequires keyutils-devel Jun 15, 2015
Move keyutils-devel to common area to fix fedora build.

Signed-off-by: Owen Synge <osynge@suse.com>
@osynge
Copy link
Author
osynge commented Jun 16, 2015

closing this patch s all is good upstream with this objective.

@osynge osynge closed this Jun 16, 2015
@osynge
Copy link
Author
osynge commented Jun 18, 2015

reopening but please dont merge yet.

@osynge osynge reopened this Jun 18, 2015
@liewegas
Copy link
Member
liewegas commented Aug 4, 2015

@osynge ping?

@ghost
Copy link
ghost commented Sep 1, 2015

@osynge please re-open when you have time

@ghost ghost closed this Sep 1, 2015
@jan--f jan--f deleted the wip_keyutils-devel branch February 8, 2017 20:45
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants