ceph.spec.in: clarify two important comments #5077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,6 +30,9 @@ Source0: http://ceph.com/download/%{name}-%{version}.tar.bz2 | |||
| %if 0%{?fedora} || 0%{?rhel} | |||
| Patch0: init-ceph.in-fedora.patch | |||
| %endif | |||
| ################################################################################# | |||
| # distro-unconditional dependencies | |||
There was a problem hiding this comment.
maybe reword unconditional -> "independent" ?
There was a problem hiding this comment.
"distro-independent dependencies" . . . dunno, sounds rather confusing.
Originally I had written "dependencies that apply across all distros" and "dependencies that are specific only to a particular distro" but that seemed too verbose. Another option would be "non-distro-specific dependencies" and "distro-specific dependencies".
There was a problem hiding this comment.
"dependencies that apply across all distro families" sounds fine to me (not too verbose)
First, the terms "common" and "specific" are vague. Second, "common" can easily be confused with the ceph-common subpackage. Fix this by rephrasing to "distro-unconditional dependencies" and "distro-conditional dependencies", respectively. Third, move the "distro-unconditional dependencies" header so it is above the part where these dependencies are actually defined. Signed-off-by: Nathan Cutler <ncutler@suse.com>
6b0e3cd
to
dd212fd
Compare
|
@ktdreyer updated |
ktdreyer
added a commit
that referenced
this pull request
Jun 25, 2015
ceph.spec.in: clarify two important comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the terms "common" and "specific" are vague. Second,
"common" can easily be confused with the ceph-common subpackage.
Fix this by rephrasing to "distro-unconditional dependencies" and
"distro-conditional dependencies", respectively.
Third, move the "distro-unconditional dependencies" header so it
is above the part where these dependencies are actually defined.
Signed-off-by: Nathan Cutler ncutler@suse.com