[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make item selector into a slice container #329

Merged
merged 1 commit into from
Jul 25, 2024
Merged

feat: make item selector into a slice container #329

merged 1 commit into from
Jul 25, 2024

Conversation

aymanbagabas
Copy link
Member

Use selector as a generic item container that holds different types. Note: selector.Selector is not concurrent safe.

@aymanbagabas aymanbagabas mentioned this pull request Jul 25, 2024
Merged
1 task
@aymanbagabas aymanbagabas force-pushed the selector-generic branch 3 times, most recently from 6b14336 to e57a264 Compare July 25, 2024 16:40
@aymanbagabas
feat: make item selector into a slice container
09b3414 
Use selector as a generic item container that holds different types.
Note: `selector.Selector` is _not_ concurrent safe.
Base automatically changed from selector to main July 25, 2024 20:21
@aymanbagabas aymanbagabas changed the base branch from main to selector July 25, 2024 20:21
@aymanbagabas aymanbagabas merged commit 88a17b6 into selector Jul 25, 2024
40 checks passed
@aymanbagabas aymanbagabas deleted the selector-generic branch July 25, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@caarlos0 caarlos0 caarlos0 approved these changes

@meowgorithm meowgorithm Awaiting requested review from meowgorithm

@maaslalani maaslalani Awaiting requested review from maaslalani

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@aymanbagabas @caarlos0