extern variables should appear in the header files

chipitsine · Jan 21, 2018 · 9e03bb5 · 9e03bb5
1 parent c2c1d65
commit 9e03bb5
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/include/h2o/http2.h b/include/h2o/http2.h
@@ -63,6 +63,7 @@ typedef struct st_h2o_http2_priority_t {
 } h2o_http2_priority_t;
 
 extern const h2o_http2_priority_t h2o_http2_default_priority;
+extern __thread h2o_buffer_prototype_t h2o_http2_wbuf_buffer_prototype;
 
 void h2o_http2_accept(h2o_accept_ctx_t *ctx, h2o_socket_t *sock, struct timeval connected_at);
 int h2o_http2_handle_upgrade(h2o_req_t *req, struct timeval connected_at);

diff --git a/include/h2o/memory.h b/include/h2o/memory.h
@@ -321,6 +321,8 @@ void h2o_dump_memory(FILE *fp, const char *buf, size_t len);
  */
 void h2o_append_to_null_terminated_list(void ***list, void *element);
 
+extern __thread h2o_mem_recycle_t h2o_mem_pool_allocator;
+
 /* inline defs */
 
 inline void *h2o_memcpy(void *dst, const void *src, size_t n)

diff --git a/lib/core/util.c b/lib/core/util.c
@@ -795,9 +795,6 @@ const char *h2o_npn_protocols = NPN_PROTOCOLS_CORE "\x08"
 
 uint64_t h2o_connection_id = 0;
 
-extern __thread h2o_buffer_prototype_t h2o_http2_wbuf_buffer_prototype;
-extern __thread h2o_mem_recycle_t h2o_mem_pool_allocator;
-
 void h2o_cleanup_thread(void)
 {
     h2o_mem_clear_recycle(&h2o_mem_pool_allocator);