[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: increment, unlambda, unslice #1298

Merged
merged 1 commit into from
Apr 15, 2023
Merged

refactor: increment, unlambda, unslice #1298

merged 1 commit into from
Apr 15, 2023

Conversation

alexandear
Copy link
Contributor
@alexandear alexandear commented Apr 13, 2023 •
edited
Loading

This PR simplifies code:

  • x++ instead of x += 1;
  • allocOpts instead of allocOpts[:];
  • modifyURL instead of func(ctx context.Context, wsURL string) (string, error) { return modifyURL(ctx, wsURL)};
  • if instead of switch for type conversion.

ZekeLu
ZekeLu requested changes Apr 13, 2023
View reviewed changes
Copy link
Member
@ZekeLu ZekeLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

allocate_test.go Outdated Show resolved Hide resolved
@alexandear alexandear changed the title refactor: remove Sprintf, increment, unlambda refactor: increment, unlambda, unslice Apr 14, 2023
@alexandear alexandear requested a review from ZekeLu April 14, 2023 08:35
ZekeLu
ZekeLu approved these changes Apr 14, 2023
View reviewed changes
Copy link
Member
@ZekeLu ZekeLu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZekeLu ZekeLu merged commit 50d488c into chromedp:master Apr 15, 2023
@alexandear alexandear deleted the refactor-simplify-code branch April 15, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZekeLu ZekeLu ZekeLu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexandear @ZekeLu