Allow auto dark mode and forcing theme #153
Conversation
| @@ -1,5 +1,8 @@ | |||
| <div x-data="{visible: true}" markdown="0"> | |||
| <div class="notification {{ include.status | default: 'is-warning' }}" x-show.transition.duration.300ms="visible"> | |||
| <div | |||
There was a problem hiding this comment.
Add margin to top and bottom of notifications
|
I kindly ask for the following change to #153: Don't make |
docs/getting-started/theming.md
Outdated
| @@ -11,6 +11,13 @@ show_sidebar: false | |||
|
|
|||
| Bulma Clean Theme uses the Bulma frontend framework. Check out the [Bulma docs](https://bulma.io/documentation/) for more information. | |||
|
|
|||
| ## Bulma Themes | |||
|
|
|||
| Bulma v1 has the concept of [themes](https://bulma.io/documentation/features/themes/) and auto detects the browsers choice for dark or light theme. | |||
There was a problem hiding this comment.
| Bulma v1 has the concept of [themes](https://bulma.io/documentation/features/themes/) and auto detects the browsers choice for dark or light theme. | |
| Bulma v1 has the concept of [themes](https://bulma.io/documentation/features/themes/) and auto detects the browser's choice for dark or light theme. |
|
|
||
| ```yaml | ||
| # With GitHub Pages Gem | ||
| remote_theme: chrisrhymes/bulma-clean-theme:v0.14.0 |
There was a problem hiding this comment.
This is much clearer, thank you! I didn't know that you could pin the version of a remote theme. That looks like a simple solution to start with.
|
|
||
| ```yaml | ||
| # _config.yml | ||
| remote_theme: chrisrhymes/bulma-clean-theme@v1.0.0 |
There was a problem hiding this comment.
Would you like this to be consistent with the README and installation pages? Both worked in my testing, so this isn't wrong.
| remote_theme: chrisrhymes/bulma-clean-theme@v1.0.0 | |
| remote_theme: chrisrhymes/bulma-clean-theme:v1.0.0 |
Thanks for your feedback. I have been thinking about this and decided to keep it as force_light by default as this is similar behaviour to how the previous version looked. You are free to set whatever value you like in your site's own _config.yml. |
Resolves #151, resolves #152