⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 35.29412% with 55 lines in your changes missing coverage. Please review.

Project coverage is 67.82%. Comparing base (3aa509d) to head (76e3729).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #513      +/-   ##
==========================================
- Coverage   68.78%   67.82%   -0.97%     
==========================================
  Files          26       26              
  Lines        3117     3173      +56     
  Branches      526      551      +25     
==========================================
+ Hits         2144     2152       +8     
- Misses        835      865      +30     
- Partials      138      156      +18     

I'm not sure if sprinkling the code with a lot of ifs is the best way forward. Some of these changes are in functions/methods that can be assumed to be part of hot code, so it will potentially have a performance impact. Moreover, if it is decided to move forward with this PR, the exception messages should be rewritten to provide the user with a solution to the problem. Something like "This node is not associated with a network; did you forget to add it using add_node()?" or similar could be an improvement.

I'm not sure if sprinkling the code with a lot of ifs is the best way forward. Some of these changes are in functions/methods that can be assumed to be part of hot code, so it will potentially have a performance impact.

Other alternatives is to mute the error with # type: ignore and let it fail in the next statement when self.network is None. The resulting error is not particularly helpful thou.