Prevent crash in `SyncProducer.stop()` if `Network.sync.start()` was not called. #128

comkieffer · 2018-11-29T19:07:11Z

If we call Network.sync.stop() before calling Network.sync.start() then _task is not defined. Int his case stop() should be a no-op.

If we call `Network.sync.stop()` before calling `Network.sync.start()` then `_task` is not defined. Int his case `stop()` should be a no-op.

Ensure that _task exists before attempting to stop it

13fc6f1

If we call `Network.sync.stop()` before calling `Network.sync.start()` then `_task` is not defined. Int his case `stop()` should be a no-op.

christiansandberg merged commit b638e62 into christiansandberg:master Nov 30, 2018

christiansandberg added this to the v0.8.1 milestone Mar 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Prevent crash in `SyncProducer.stop()` if `Network.sync.start()` was not called. #128

Prevent crash in `SyncProducer.stop()` if `Network.sync.start()` was not called. #128

Prevent crash in SyncProducer.stop() if Network.sync.start() was not called. #128

Prevent crash in SyncProducer.stop() if Network.sync.start() was not called. #128

Conversation

Prevent crash in `SyncProducer.stop()` if `Network.sync.start()` was not called. #128

Prevent crash in `SyncProducer.stop()` if `Network.sync.start()` was not called. #128