Transports are responsible for batching messages #360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
|
LGTM |
Signed-off-by: Christoph Neijenhuis <christoph.neijenhuis@commercetools.de>
4efedf8
to
ed3b17e
Compare
|
Approved on the Jan 17 call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to the discussions in #330 and #282 : Since it seems to be a frequently asked question, we should somewhere in the spec write down how to handle multiple messages.
I think the
primer.mdis the place that fits best. I'm not sure if the Design Goal section is a perfect fit, but I didn't find a better place.