Prevent queuing writes while internal writable is being piped #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
commented
Mar 19, 2024
jasnell
commented
Mar 19, 2024
jasnell
commented
Mar 19, 2024
This comment was marked as outdated.
This comment was marked as outdated.
135f304
to
cd077e0
Compare
dom96
approved these changes
Mar 19, 2024
Previously, the internal writable would allow queuing additional write events while it was being piped. This would lead to an assert when the pipe finished because of the expectation that the Pipe event is the last item in the queue. We can continue to write to the stream once the piping is done as long as preventClose is true.
cd077e0
to
4d0af28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some uses we end up enqueuing a write event to a
WritableStreamInternalControllerwhile it is being piped to, leading to an assertion given that we expect thePipeevent to be the last event in the queue while it is being piped. To match the behavior seen when using theWritableStreamDefaultWriter, we should reject attempts to write, close, or flush while the pipe is still going.Also improves the logging around the assertion that was being hit and fixes another apparent latent bug in the pipe source close check.