Prevent queuing writes while internal writable is being piped #1861
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some uses we end up enqueuing a write event to a
WritableStreamInternalController
while it is being piped to, leading to an assertion given that we expect thePipe
event to be the last event in the queue while it is being piped. To match the behavior seen when using theWritableStreamDefaultWriter
, we should reject attempts to write, close, or flush while the pipe is still going.Also improves the logging around the assertion that was being hit and fixes another apparent latent bug in the pipe source close check.