[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: slim template with deepcopy #1067

Merged
merged 1 commit into from
Aug 14, 2023
Merged

fix: slim template with deepcopy #1067

merged 1 commit into from
Aug 14, 2023

Conversation

jayantxie
Copy link
Member

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

fix: slim模板带deepcopy api生成代码错误问题

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@jayantxie jayantxie requested review from a team as code owners August 11, 2023 10:47
@codecov
Copy link
codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02% 🎉

Comparison is base (5866e64) 68.94% compared to head (a55dc3d) 68.96%.

❗ Current head a55dc3d differs from pull request most recent head cf6614c. Consider uploading reports for the commit cf6614c to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1067      +/-   ##
===========================================
+ Coverage    68.94%   68.96%   +0.02%     
===========================================
  Files          252      252              
  Lines        18812    18812              
===========================================
+ Hits         12970    12974       +4     
+ Misses        4652     4650       -2     
+ Partials      1190     1188       -2

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jayantxie jayantxie merged commit c8f3669 into develop Aug 14, 2023
30 checks passed
@jayantxie jayantxie deleted the fix/slim_tmpl_with_deepcopy branch August 14, 2023 02:58
jieqiboh pushed a commit to jieqiboh/kitex that referenced this pull request Aug 17, 2023
@jayantxie @jieqiboh
fix: slim template with deepcopy (cloudwego#1067)
ba6355c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppzqh ppzqh ppzqh approved these changes

@HeyJavaBean HeyJavaBean HeyJavaBean approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jayantxie @ppzqh @HeyJavaBean