[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(retry): support customize retry policy key #1363

Merged
merged 2 commits into from
Jul 1, 2024
Merged

feat(retry): support customize retry policy key #1363

merged 2 commits into from
Jul 1, 2024

Conversation

whalecold
Copy link
Member

What type of PR is this?

feat

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

支持自定义重试策略的 的 key 值

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
zh(optional):

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@whalecold whalecold requested review from a team as code owners May 28, 2024 12:22
@whalecold whalecold mentioned this pull request May 28, 2024
Open
ppzqh
ppzqh reviewed May 29, 2024
View reviewed changes
pkg/retry/retryer.go Outdated Show resolved Hide resolved
@YangruiEmma
Copy link
Member

Could you please describe that why do you need this feature?

@whalecold
Copy link
Member Author
whalecold commented Jun 3, 2024 •
edited
Loading

Could you please describe that why do you need this feature?

I am trying to implement the feature: xDS retry integration to Istio and find that the istio rule does not have the method dimension configuration in native. The circuitbreak can customize the config key, so I want the similar mechanism with retry.

@whalecold whalecold force-pushed the feat/retry branch 2 times, most recently from 08068f8 to 6508460 Compare June 27, 2024 08:25
@ppzqh
Copy link
Contributor
ppzqh commented Jul 1, 2024

/LGTM

@YangruiEmma YangruiEmma merged commit bbe4a39 into cloudwego:develop Jul 1, 2024
20 checks passed
@whalecold whalecold deleted the feat/retry branch July 1, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YangruiEmma YangruiEmma YangruiEmma approved these changes

@ppzqh ppzqh ppzqh approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@whalecold @YangruiEmma @ppzqh