[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: EnableSkipDecoder switch not working in Buffer Protocol scenario #1378

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

DMwangnima
Copy link
Contributor

What type of PR is this?

fix

Check the PR title.

  • This PR title match the format: <type>(optional scope): <description>
  • The description of this PR title is user-oriented and clear enough for others to understand.
  • Attach the PR updating the user documentation if the current PR requires user awareness at the usage level. User docs repo

(Optional) Translate the PR title into Chinese.

修复:EnableSkipDecoder 开关在 Buffer 协议场景下不生效

(Optional) More detailed description for this PR(en: English/zh: Chinese).

en:
In the Buffer scenario, dataLen will be negative. unmarshalThriftData doesn't take this into account, leading to the logic even if SkipDecoder is not turned on.
zh(optional):
在 Buffer 场景下, dataLen 会为负数,unmarshalThriftData 没有考虑到这种情况导致即使 SkipDecoder 没有开启也会走到相关逻辑

(Optional) Which issue(s) this PR fixes:

(optional) The PR that updates user documentation:

@DMwangnima DMwangnima requested review from a team as code owners June 7, 2024 08:12
@DMwangnima DMwangnima merged commit c028c86 into cloudwego:develop Jun 7, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants