Migrate from github.com/golang/protobuf to google.golang.org/protobuf #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
adisuissa
reviewed
Mar 21, 2024
| "@io_bazel_rules_go//proto/wkt:struct_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:timestamp_go_proto", | ||
| "@io_bazel_rules_go//proto/wkt:wrappers_go_proto", | ||
| "@org_golang_google_protobuf//types/known/anypb:go_default_library", |
There was a problem hiding this comment.
I would like this change to go through Envoy first (https://github.com/envoyproxy/envoy/blob/main/api/bazel/api_build_system.bzl) before landing it here. Hopefully it will be picked up by go-control-plane, and we'll be able to observe any issues ahead of time. WDYT?
There was a problem hiding this comment.
Hi @adisuissa ,
I have applied this fix on envoy with this : envoyproxy/envoy#33048
Is it enough testing for you ?
adisuissa
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
github.com/golang/protobufhas been superseded bygoogle.golang.org/protobufThis migrates old protobuf leftovers to new version of protobuf