[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphonenumber: new recipe #23689

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

valgur
Copy link
Contributor
@valgur valgur commented Apr 21, 2024

Adds libphonenumber: https://github.com/google/libphonenumber

Google's common Java, C++ and JavaScript library for parsing, formatting, and validating international phone numbers.

I have tested the package with all of the options enabled and disabled. Everything worked as expected, except for:

  • use_re2=True failing with a compilation error,
  • use_icu_regexp=False failing when linking test_package.

Packaging status

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

recipes/libphonenumber/all/conanfile.py Outdated Show resolved Hide resolved
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 8 (282dbb0f860fe3c6fda4d4bae047a162ad9ddcab):

  • libphonenumber/8.13.35:
    All packages built successfully! (All logs)

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 8 (282dbb0f860fe3c6fda4d4bae047a162ad9ddcab):

  • libphonenumber/8.13.35:
    CI failed to create some packages (All logs)

    Logs for packageID 44a79f5bd5271032b49ee6e93628b45ffb7ef70a:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=msvc
    compiler.cppstd=14
    compiler.runtime=dynamic
    compiler.runtime_type=Release
    compiler.version=193
    os=Windows
    [options]
    */*:shared=False
    
    [...]
    -- Conan: Component target declared 'absl::log_initialize'
    -- Conan: Component target declared 'absl::random_random'
    -- Conan: Component target declared 'absl::status'
    -- Conan: Component target declared 'absl::statusor'
    -- Conan: Component target declared 'absl::flat_hash_set'
    -- Conan: Component target declared 'absl::node_hash_set'
    -- Conan: Component target declared 'absl::raw_hash_map'
    -- Conan: Component target declared 'absl::log_internal_log_sink_set'
    -- Conan: Component target declared 'absl::log_sink_registry'
    -- Conan: Component target declared 'absl::flat_hash_map'
    -- Conan: Component target declared 'absl::node_hash_map'
    -- Conan: Component target declared 'absl::flags_reflection'
    -- Conan: Component target declared 'absl::flags'
    -- Conan: Component target declared 'absl::flags_usage_internal'
    -- Conan: Component target declared 'absl::flags_usage'
    -- Conan: Component target declared 'absl::flags_parse'
    -- Conan: Component target declared 'absl::log_internal_flags'
    -- Conan: Component target declared 'absl::log_internal_message'
    -- Conan: Component target declared 'absl::log_internal_strip'
    -- Conan: Component target declared 'absl::log_flags'
    -- Conan: Component target declared 'absl::log_internal_structured'
    -- Conan: Component target declared 'absl::log_structured'
    -- Conan: Component target declared 'absl::log_internal_check_op'
    -- Conan: Component target declared 'absl::log_internal_log_impl'
    -- Conan: Component target declared 'absl::absl_log'
    -- Conan: Component target declared 'absl::log'
    -- Conan: Component target declared 'absl::log_streamer'
    -- Conan: Component target declared 'absl::log_internal_check_impl'
    -- Conan: Component target declared 'absl::absl_check'
    -- Conan: Component target declared 'absl::check'
    -- Conan: Component target declared 'absl::die_if_null'
    -- Conan: Target declared 'abseil::abseil'
    -- Conan: Including build module from 'C:/J/workspace/prod-v2/bsr@4/26340/cfdff/p/absei5af7158e3486f/p/lib/cmake/conan_trick/cxx_std.cmake'
    CMake Error at CMakeLists.txt:39 (message):
      Can't find Google Protocol Buffers: can't locate protobuf.  Please read the
      README.
    Call Stack (most recent call first):
      CMakeLists.txt:59 (print_error)
      CMakeLists.txt:177 (find_required_library)
    
    
    -- Configuring incomplete, errors occurred!
    See also "C:/J/workspace/prod-v2/bsr@4/26340/cfdff/p/b/libphfea54882eeb3c/b/build/CMakeFiles/CMakeOutput.log".
    
    libphonenumber/8.13.35: ERROR: 
    Package '44a79f5bd5271032b49ee6e93628b45ffb7ef70a' build failed
    libphonenumber/8.13.35: WARN: Build folder C:\J\workspace\prod-v2\bsr@4\26340\cfdff\p\b\libphfea54882eeb3c\b\build
    ERROR: libphonenumber/8.13.35: Error in build() method, line 154
    	cmake.configure(build_script_folder=os.path.join(self.source_folder, "cpp"))
    	ConanException: Error 1 while executing
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants