[go: nahoru, domu]
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ImagePullPolicy ignored for CCRuntime #395

Open
teodor-pripoae opened this issue Jul 16, 2024 · 0 comments
Open

ImagePullPolicy ignored for CCRuntime #395

teodor-pripoae opened this issue Jul 16, 2024 · 0 comments

Comments

@teodor-pripoae
Copy link

ImagePullPolicy is set to never in the runtime manifest but pods for pre-install use ImagePullPolicy: Always

To Reproduce

apiVersion: confidentialcontainers.org/v1beta1
kind: CcRuntime
metadata:
  name: ccruntime-sample
  namespace: confidential-containers-system
spec:
  ccNodeSelector:
    matchLabels:
      node.kubernetes.io/worker: ""
  config:
    cleanupCmd:
    - /opt/kata-artifacts/scripts/kata-deploy.sh
    - reset
    debug: false
    defaultRuntimeClassName: kata-qemu
    environmentVariables:
    - name: INSTALL_OFFICIAL_CONTAINERD
      value: "false"
    imagePullPolicy: Never
    installCmd:
    - /opt/kata-artifacts/scripts/kata-deploy.sh
    - install

Describe the results you expected
Pods having ImagePullPolicy always

Describe the results you received:

kubectl -n confidential-containers-system get pod cc-operator-pre-install-daemon-d2d4l -o yaml | grep imagePull
    imagePullPolicy: Always

Additional context
https://github.com/confidential-containers/operator/blob/main/controllers/ccruntime_controller.go#L920
teodor-pripoae added a commit to teodor-pripoae/confidential-containers-operator that referenced this issue Jul 18, 2024
@teodor-pripoae
fix: add support for imagePullPolicy for installer daemonsets (confid…
bfab94e 
…ential-containers#395)
teodor-pripoae added a commit to teodor-pripoae/confidential-containers-operator that referenced this issue Jul 18, 2024
@teodor-pripoae
fix: add support for imagePullPolicy for installer daemonsets (confid…
9e25c3a 
…ential-containers#395)

Signed-off-by: Teodor <teodor.pripoae@gmail.com>
teodor-pripoae added a commit to teodor-pripoae/confidential-containers-operator that referenced this issue Jul 18, 2024
@teodor-pripoae
fix: add support for imagePullPolicy for installer daemonsets (confid…
63e716c 
…ential-containers#395)

Signed-off-by: Teodor <teodor.pripoae@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@teodor-pripoae