gha: ccruntime_e2e: Do **NOT** fail fast and add a timeout for the test execution #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every now and then we'll face errors that may be different depending on the distro being used, due to some distro changes or even some flakiness in the tests. Till everything is 100% stable, which is not the case yet, we better allow the tests to finish even if one test fails, giving us a better idea of the problem being a generic one or specific to flakiness / one distro. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
ldoktor
reviewed
Jan 2, 2024
ldoktor
reviewed
Jan 2, 2024
Today I've faced one test hanging for more than one hour, stuck, without giving us any useful information, leaving the "cancel" option (which is up to the user to do) as the only option to finish the test and re-start it. As a possible way to avoid wasting resources for too long, let's simply add a timeout of 45 minutes in the execution of the e2e tests. This is 10 minutes more than what's been observed as the total time taken by this step. Signed-off-by: Fabiano Fidêncio <fabiano.fidencio@intel.com>
06b747c
to
5c53644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gha: ccruntime_e2e: Avoid fail-fast
Every now and then we'll face errors that may be different depending on
the distro being used, due to some distro changes or even some flakiness
in the tests.
Till everything is 100% stable, which is not the case yet, we better
allow the tests to finish even if one test fails, giving us a better
idea of the problem being a generic one or specific to flakiness / one
distro.
gha: ccruntime_e2e: Add a 30 minutes timeout
Today I've faced one test hanging for more than one hour, stuck, without
giving us any useful information, leaving the "cancel" option (which is
up to the user to do) as the only option to finish the test and re-start
it.
As a possible way to avoid wasting resources for too long, let's simply
add a timeout of 30 minutes in the execution of the e2e tests. This is
10 minutes more than what's been observed as the total time taken by
this step.
This is related to #309, but doesn't cover the tests split into reusable parts.