[go: nahoru, domu]

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error on rebasing pr branch atop of target one #326

Merged

Conversation

BbolroC
Copy link
Member
@BbolroC BbolroC commented Jan 17, 2024

There are 2 issues identified during the follow-up test for #295.

  • git-helper.sh misses an execution permission
  • actions/checkout@v4 does not fetch the code from the git ref of a pull request.

This PR is to fix these issues.

Signed-off-by: Hyounggyu Choi Hyounggyu.Choi@ibm.com

@wainersm wainersm self-requested a review January 17, 2024 18:46
Copy link
Member
@wainersm wainersm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BbolroC !

This is to fix 2 issues identified during the follow-up test for confidential-containers#295.

 - git-helper.sh misses an execution permission
 - actions/checkout@v4 does not fetch the code from the git ref

This commit is to fix these issues.

Signed-off-by: Hyounggyu Choi <Hyounggyu.Choi@ibm.com>
@BbolroC BbolroC changed the title Set execution permission to git-helper.sh Fix error on rebasing pr branch atop of target one Jan 17, 2024
Copy link
Member
@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenhorsman stevenhorsman merged commit 14e0028 into confidential-containers:main Jan 17, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants